Skip to content

Conversation

@ryanzhang-oss
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
Fix the perfromance issues that caused by the network agents update the IMC unnecessarily when there is status change.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

Signed-off-by: Ryan Zhang <yangzhangrice@hotmail.com>
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.90%. Comparing base (20d3adf) to head (728bfa9).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...nternalmembercluster/v1beta1/controller_v1beta1.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   66.98%   66.90%   -0.08%     
==========================================
  Files          33       33              
  Lines        3786     3783       -3     
==========================================
- Hits         2536     2531       -5     
- Misses       1074     1077       +3     
+ Partials      176      175       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanzhang-oss ryanzhang-oss merged commit c51f961 into main Jan 21, 2026
8 of 10 checks passed
"fmt"
"time"

clusterv1beta1 "go.goms.io/fleet/apis/cluster/v1beta1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be with the fleet packages down below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, didn't pay attention to the import group, will fix it in a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants