support for azurestack - #14
Conversation
|
bganapa sarathys Usha N (@N-Usha) Ashish Ranjan (@asranja) please review |
|
Few suggestions:
Rakesh Kumar (@rakku-ms) Since we already added suffixes while registering AzureStack cloud. Can we not get them directly using this method. |
|
Ashish Ranjan (@asranja) please review this PR in Authorizer code: microsoft/pipelines-appservice-lib#31 When is your team planning to update the azure-actions-webclient version? "dependencies": { |
2e2ac17 to
13d8466
Compare
|
Ashish Ranjan (@asranja) this repo is using the older version of Authorizer code which may take sometime to upgrade. So I have added the 'executeAzCliCommand' function in the keyvault code itself as a workaround for now. We don't need the additional parameter 'environment' now for this keyvault action. Please review and maybe create separate branch for AzureStack just like we did for login action. |
|
Manish Narula (@narula0781), Chandra Mudili (@chandrasekharmudili) any update regarding this PR? are you planning to merge this to master or create a separate beta branch for AzureStack? |
|
Rakesh Kumar (@rakku-ms) could you update your branch and fix the merge conflicts? |
0c8d1e6 to
f09fe5e
Compare
f09fe5e to
cbd4d08
Compare
|
DS-MS I fixed all merge conflicts with the master. Can you please merge this PR? Successful runs: |
* add workflow * support for azurestack * review changes
* support for azurestack (#14) * add workflow * support for azurestack * review changes * Adding compiled changes Co-authored-by: Rakesh Kumar <rakku@microsoft.com>
test against
azure: https://github.com/rakku-ms/get-keyvault-secrets/actions/runs/292243295
azurestack: https://github.com/rakku-ms/get-keyvault-secrets/actions/runs/292243294