Fix deploy scripts for ACR task builds without local Docker#54
Open
placerda wants to merge 7 commits into
Open
Fix deploy scripts for ACR task builds without local Docker#54placerda wants to merge 7 commits into
placerda wants to merge 7 commits into
Conversation
Enable network-isolated deployments to use ACR remote builds without requiring Docker on the jumpbox. Propagate/consume ACR_TASK_AGENT_POOL and fail fast on unsupported post-provision prerequisites instead of silently masking errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Fixed by Validation completed with a fresh basic deployment:
No changes were made under the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes UI deployment work in network-isolated environments where Docker is intentionally not installed on the jumpbox.
BUILD_MODE=local|acr-taskselection.acr-taskwhenNETWORK_ISOLATION=trueorACR_TASK_AGENT_POOLis set.az acr buildinstead of local Docker in remote mode.--agent-pool $ACR_TASK_AGENT_POOLwhen present and validates the pool first.BUILD_MODE=local.Related upstream blocker
The deploy script now uses the correct ACR Task path, but the current landing-zone ACR Tasks pool still needs outbound/mirror support for public base images and package feeds: Azure/bicep-ptn-aiml-landing-zone#66.
Validation
scripts/deploy.ps1with PowerShell parser.scripts/deploy.shwith Git Bashbash -n.