Skip to content

Change prefixes dtv: and aov: to dov: and provide legacy support#1335

Merged
jrdouceur merged 5 commits into
mainfrom
johndo/wot-dov-prefix
May 26, 2026
Merged

Change prefixes dtv: and aov: to dov: and provide legacy support#1335
jrdouceur merged 5 commits into
mainfrom
johndo/wot-dov-prefix

Conversation

@jrdouceur
Copy link
Copy Markdown
Contributor

No description provided.

@jrdouceur jrdouceur marked this pull request as ready for review May 18, 2026 18:22
Copilot AI review requested due to automatic review settings May 18, 2026 18:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Comment thread wot-codegen/src/Dtdl2Wot/Command/t4/CommandAffordance.cs
@vaavva
Copy link
Copy Markdown
Member

vaavva commented May 26, 2026

any readmes or the schemas in the wot-codegen/schema folder that need to be updated with this change?

Copy link
Copy Markdown
Member

@vaavva vaavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved if nothing else needed for other open comment

@jrdouceur
Copy link
Copy Markdown
Contributor Author

any readmes or the schemas in the wot-codegen/schema folder that need to be updated with this change?

Yes, but (a) the schemas are slightly out-of-date in another way as well, (b) there will be a bunch of additional properties getting added soon, and (c) this PR is already very large due to changes in converted models. So, my plan had been to update the schemas in another PR.

@jrdouceur jrdouceur merged commit b1efd81 into main May 26, 2026
15 checks passed
@jrdouceur jrdouceur deleted the johndo/wot-dov-prefix branch May 26, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants