fix(e2e): wait for webhook before testing PVC rejection#412
Merged
Conversation
jmclong
force-pushed
the
dev/jlong/fix-flakes
branch
from
ad23af0 to
c8c2b58
Compare
jmclong
force-pushed
the
dev/jlong/fix-flakes
branch
from
c8c2b58 to
a498e52
Compare
The lvmWebhookRejectTest flakes because the ValidatingWebhookConfiguration (csi-local-enforce-ephemeral) has failurePolicy: Ignore. When the webhook endpoint isn't reachable yet, the API server silently allows the PVC through instead of rejecting it. Add VerifyWebhookServing() that uses kubectl apply --dry-run=server to confirm the webhook is actually serving before running the rejection test. The dry-run goes through the full admission pipeline without persisting to etcd. This check runs as its own test step after the storageclass is created (the webhook allows PVCs whose storageclass doesn't exist). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jmclong
force-pushed
the
dev/jlong/fix-flakes
branch
from
a498e52 to
7630b50
Compare
croomes
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lvmWebhookRejectTest flakes because the ValidatingWebhookConfiguration (csi-local-enforce-ephemeral) has failurePolicy: Ignore. When the webhook endpoint isn't reachable yet, the API server silently allows the PVC through instead of rejecting it.
Add VerifyWebhookServing() that uses kubectl apply --dry-run=server to confirm the webhook is actually serving before running the rejection test. The dry-run goes through the full admission pipeline without persisting to etcd. This check runs as its own test step after the storageclass is created (the webhook allows PVCs whose storageclass doesn't exist).