Adding FIC Code#112
Conversation
|
@sahneysumant please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
| .PHONY: manifests | ||
| manifests: $(CONTROLLER_GEN) ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| $(CONTROLLER_GEN) rbac:roleName=acrpull-controller crd paths="./..." output:dir=config/helm/templates output:crd:artifacts:config=config/helm/templates | ||
| $(shell cygpath -u "$(GOBIN)/controller-gen-v0.14.0") rbac:roleName=acrpull-controller crd paths="./api/v1beta1" paths="./api/v1beta2" paths="./internal/controller" output:dir=config/helm/templates output:crd:artifacts:config=config/helm/templates |
There was a problem hiding this comment.
cygpath is only present in Cygwin installations. Shouldn't this be more portable in case its used in WSL etc?
| properties: | ||
| scope: | ||
| description: |- | ||
| TenantID holds an optional tenant identifier of a federated identity. |
There was a problem hiding this comment.
Is this description correct. This is the target scope right?
| service account and the identity to use for image pulling is not the | ||
| default identity stored in the service account's annotations. The | ||
| client and tenant ID must be specified together. | ||
| example: 72f988bf-86f1-41af-91ab-2d7cd011db47 |
There was a problem hiding this comment.
Better to make this AME or prdtrs01 right? Those are the only allowed combinations when originating from a ME/trs tenant.
| var audience string = env.Services[cloud.ResourceManager].Audience | ||
|
|
||
| if spec.Auth.FederatedIdentity != nil { | ||
| audience = "api://AzureADTokenExchange" |
There was a problem hiding this comment.
Feel this should be switched based on the target environment.
| // service account and the identity to use for image pulling is not the | ||
| // default identity stored in the service account's annotations. The | ||
| // client and tenant ID must be specified together. | ||
| Scope string `json:"scope,omitempty"` |
There was a problem hiding this comment.
nit: Missing comment, it's same as for tenantid
No description provided.