[code sync] Merge code from sonic-net/sonic-gnmi:master to kubesonic - #234
Merged
Merged
Conversation
mssonicbld
commented
Sep 16, 2026
mssonicbld
commented
Collaborator
…hods (#782) Description Moves the readonly/readwrite role check in authenticate() out of the cert-only branch into a shared checkRoleAccess() helper, and runs it once after any authentication mechanism succeeds. Motivation and Context The role check previously only executed inside the client-certificate authentication branch. Clients authenticating via password or JWT bypassed the readonly/readwrite role gate entirely. This change applies the same role check uniformly regardless of which authentication mechanism succeeded. Semantics are unchanged: same role postfix handling (noaccess/readonly/readwrite), same ConfigTableName guard, same fail-closed-on-writes behavior when no matching role is found. How Has This Been Tested? gofmt -l reports no formatting issues. Full go build ./... was not achievable in this environment due to pre-existing local toolchain gaps unrelated to this change (missing generated swsscommon bindings, a libyang C header/API mismatch, missing PAM dev headers) — confirmed by building the unmodified upstream gnmi_server package in the same environment, which fails with the identical errors. No unit test changes were made.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.