[code sync] Merge code from sonic-net/sonic-gnmi:master to kubesonic - #235
Merged
Merged
Conversation
mssonicbld
commented
Sep 17, 2026
mssonicbld
commented
Collaborator
* Make redis client pool size configurable via GNMI_REDIS_POOL_SIZE After the go-redis v9 migration (#528), each redis client defaults its PoolSize to 10*GOMAXPROCS, which scales with logical CPUs. GNMI creates one client per DB per namespace, so telemetry RSS grows with CPU count (sonic-net/sonic-buildimage#26825). Add dbconfig.ApplyRedisPoolSize() which sets PoolSize from the GNMI_REDIS_POOL_SIZE env var. When the var is unset or invalid, the default pool size is left unchanged. Applied to all production redis client creations. Signed-off-by: Michael Ma <kema2@microsoft.com> * Address review comments - redis_pool.go: drop package-doc form on second file; separate parse-error from non-positive value in the warning; add unit tests - notification_producer.go: remove dead redis.NewClient nil check and now-unused fmt import - connection_manager.go: use table constant and handle HGetAll error Signed-off-by: Michael Ma <kema2@microsoft.com> * [redis]: Keep pool configuration pure Move the Redis pool option helper into internal/redisopts so pure packages do not pull in SONiC database dependencies. Copilot-Session: 3370a3d4-d863-4ca6-93a6-1a11592a89bb Signed-off-by: Michael Ma <kema2@microsoft.com> * [redis]: Centralize common option configuration Route every production redis.Options construction through redisopts.New so future shared settings only require one implementation change. Copilot-Session: 3370a3d4-d863-4ca6-93a6-1a11592a89bb Signed-off-by: Michael Ma <kema2@microsoft.com> --------- Signed-off-by: Michael Ma <kema2@microsoft.com> Copilot-Session: 3370a3d4-d863-4ca6-93a6-1a11592a89bb
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
mssonicbld
force-pushed
the
sonicbld/kubesonic-merge
branch
from
September 18, 2026 03:03
c0b461f to
64c4b3a
Compare
Collaborator
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.