[code sync] Merge code from sonic-net/sonic-host-services:202605 to 202608 - #20
Merged
Merged
Conversation
mssonicbld
commented
Aug 14, 2026
mssonicbld
commented
Collaborator
…424) What I did: I updated device_metadata_handler in hostcfgd so that hostname, timezone, and rsyslog handling run only when the CONFIG_DB notification is for the localhost row. For any other DEVICE_METADATA key (for example bmc), the handler logs once at INFO and returns without calling hostname_update, timezone_update, or rsyslog_config. Why I did it: DEVICE_METADATA can have multiple keys; host settings live under localhost, while BMC fields live under bmc. The handler used to ignore the row key and always ran hostname logic, so bmc updates passed a dict without hostname, which produced ERR (“Hostname was not updated: Empty not allowed”). How to verify Change DEVICE_METADATA|bmc and confirm no "ERR Empty not allowed" in syslog. Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.