Skip to content

[code sync] Merge sonic-host-services 202605 into 202608 - #21

Merged
Lun Yue (lunyue-ms) merged 2 commits into
Azure:202608from
mssonicbld:copilot/code-sync-host-services-202608-6aa22edd
Sep 10, 2026
Merged

Lun Yue (lunyue-ms) merged 2 commits into
Azure:202608from
mssonicbld:copilot/code-sync-host-services-202608-6aa22edd

Conversation

@mssonicbld

Copy link
Copy Markdown
Collaborator

Resolve the code-sync conflict reported in work item 39608223 by merging the exact requested upstream revision, not a newer branch tip.

Provenance

Role Revision
Target Azure/sonic-host-services.msft 202608, starting at e590a35c8bbfaf44bac9c1bf122f9214e7959927
Source sonic-net/sonic-host-services 202605, exact requested cd0f04a5d4a107b9f058b2d3033aa846ee6cb958
Repair d2431244705b93d6d4c2a83eab15feedff9abdfe

The live submodule sync policy maps the target to the public source branch above. The sync configuration includes src/sonic-host-services. Original notification: pipeline run 1215463.

Resolution

  • Resolve all five textual conflict regions in scripts/caclmgrd: keep independent RedfishAllowed and DhcpServerSyslogAllowed defaults and persisted FEATURE initialization, retain the REDFISH enable/disable helpers, and dispatch both features through handle_feature_state_events.
  • Drain the shared FEATURE subscription once. Calling two separate draining handlers would consume and discard the other feature's notifications. Each actual state transition queues an ACL rebuild; unrelated keys and unchanged states remain no-ops.
  • Preserve Azure's feature-gated REDFISH TCP/443 ACLs and the upstream host-only IPv4 docker0 TCP/2514 syslog exception before the catch-all DROP.
  • Keep existing REDFISH and DHCP assertions, update REDFISH callers to the unified handler, and add mixed-queue cases in both event orders, including repeated notifications, unrelated events, independent deletions, and full queue draining.

Validation and limitations

  • Read the full resolved daemon and both affected test modules. Repository-wide searches found no conflict markers or stale handle_redfish_feature_events references. Confirmed one FEATURE subscription, one handler, and one event-loop call.
  • Before publishing, HEAD and ORIG_HEAD matched the target revision and MERGE_HEAD matched the exact requested source. Trusted publication produced a merge commit, confirmed by the local reflog. No cherry-pick, squash, rebase, or newer source-tip substitution was used.
  • Executable tests, syntax compilation, and an independent remote parent/diff query were unavailable: this task exposes file and trusted repository tools, but no shell/test executor or GitHub read API. Static inspection is not a passing test result. CI must run pytest tests/caclmgrd/caclmgrd_redfish_acl_test.py tests/caclmgrd/caclmgrd_dhcp_server_syslog_test.py in the existing SONiC test environment.

Merge requirement

Complete this PR using Create a merge commit / no-fast-forward. Do not squash or rebase, because the exact upstream source must remain in the target's ancestry. This task does not merge the PR or enable auto-merge.

Xichen96 and others added 2 commits September 8, 2026 19:59
…(#426)

Manual 202605 backport of sonic-net/sonic-host-services#412.

The release branch does not contain the separate REDFISH feature implementation, so retain a DHCP-only FEATURE event handler and its dedicated unit coverage.

(cherry picked from commit f913bf925a64ec09fdab3c8fead918cdbc3e0f0c)

Signed-off-by: Xichen96 <lukelin0907@gmail.com>
Copilot-Session: 8b98940f-1ce7-4b16-ae0c-bf2f235c2bb2
Merge exact upstream commit cd0f04a into Azure target e590a35.

Resolve caclmgrd FEATURE-event conflicts with one queue consumer that preserves Azure REDFISH ACL gating and upstream DHCP-server docker0 syslog handling. Keep both persisted feature flags and schedule ACL rebuilds independently on state changes.

Update REDFISH handler coverage and add mixed-feature event-order, no-op, and deletion regression cases.

Signed-off-by: Elastictest AI Worker <sonicbld@microsoft.com>
@lunyue-ms
Lun Yue (lunyue-ms) merged commit 409d3b2 into Azure:202608 Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants