invalid macsec link metadata minigraph xml generation

[sivanuka]

• regression added by 05a6979
• with macsec_card=True generating invalid minigraph xml( missing declaration tag )
• generating below xml without declaration
  <a:LinkMetadata> </a:LinkMetadata>
• below is the valid xml
  <LinkMetadataDeclaration> <Link xmlns:a="http://schemas.datacontract.org/2004/07/Microsoft.Search.Autopilot.Evolution"> <a:LinkMetadata> </a:LinkMetadata> </Link> </LinkMetadataDeclaration>

Proposed fix:

• We need to back port the changes of Address fixes to make sure t2 topology deploy works with and without macsec enabled. sonic-net/sonic-mgmt#17530
  or
• revert problematic line https://github.com/Azure/sonic-mgmt.msft/blob/202405/ansible/templates/minigraph_link_meta.j2#L3

invalid generated xml without declaration tags
</MetadataDeclaration> <a:LinkMetadata> <a:Name i:nil="true"/> <a:Properties> <a:DeviceProperty> <a:Name>MacSecEnabled</a:Name> <a:Value>True</a:Value> </a:DeviceProperty> </a:Properties> <a:Key>ARISTA01T3:Ethernet1;cmp214-5:Ethernet5/1</a:Key> </a:LinkMetadata> <a:LinkMetadata> <a:Name i:nil="true"/> <a:Properties> <a:DeviceProperty> <a:Name>MacSecEnabled</a:Name> <a:Value>True</a:Value> </a:DeviceProperty> </a:Properties> <a:Key>ARISTA01T3:Ethernet2;cmp214-5:Ethernet7/1</a:Key> </a:LinkMetadata>

[sivanuka]

Tagging judyjoseph