Conversation
Signed-off-by: Lin Jin <linjin@microsoft.com>
Signed-off-by: Lin Jin <linjin@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
LinJin23
marked this pull request as ready for review
September 8, 2026 15:43
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1403 in repo Azure/sonic-mgmt.msft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Serialize ASIC_DB route snapshot collection on the controller to avoid flaky failures from concurrent pytest-ansible calls.
Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): https://msazure.visualstudio.com/One/_workitems/edit/38896300/?view=edit
Failure type: other - test infrastructure race condition
Tested branch
Test result
Approach
What is the motivation for this PR?
get_route_prefix_snapshot_from_asicdblaunches concurrent controller threads that reuse the same pytest-ansible/SonicHost dispatcher. In the observed failures, one Ansible transaction raisedAnsibleConnectionFailureand did not post its completion signal, causing the main thread to report a route snapshot timeout.How did you do it?
Removed the controller-side threading and queue logic and collected each ASIC snapshot serially.
How did you verify/test it?
Ran
route/test_route_consistency.pyon 202511; all 4 test cases passed.Any platform specific information?
The failure was observed on an Arista-7280DR3AM-36 multi-ASIC HWSKU. The change is not platform-specific.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A