Conversation
Signed-off-by: Lin Jin <linjin@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Ensure transceivers intentionally skipped by the LPMODE validation are still flapped after
sfp.reset().is_xcvr_support_lpmode()returnsFalsefor entries inLPMODE_SKIP_LIST. The reset test previously reused that result to select interfaces for recovery, so those transceivers were reset but omitted from the shutdown/startup flap. On affected Arista 7280DR3 systems with Cloud Light 7123-G37 modules, the transceiver remained in low-power mode and the interface stayed operationally down.Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): https://msazure.visualstudio.com/One/_workitems/edit/38573079
Failure type: day-one issue
Tested branch
Test result
python3 -m py_compile tests/platform_tests/api/test_sfp.pypassed. Hardware validation is pending.SONiC.20251110.42- https://elastictest.org/scheduler/testplan/6a6e1284c4dbc22bce9ce727?testcase=platform_tests%2Fapi%2Ftest_sfp.py&type=console. Post-fix hardware validation is pending.Approach
What is the motivation for this PR?
Known-problem transceivers must skip direct LPMODE API validation, but they still require interface recovery after SFP reset. Treating both decisions as the same condition leaves the interfaces operationally down and causes the reset test and its BGP teardown to fail.
How did you do it?
Extracted the existing LPMODE skip-list match into
should_skip_lpmode_check()and reused it when selecting interfaces to flap after reset. This keeps LPMODE API checks skipped for known-problem modules while still restoring their interfaces. The existing flat-memory handling on master remains unchanged.How did you verify/test it?
Pre-commit hooks and Python compilation passed. The failure was reproduced on the 202511 image linked above; post-fix hardware validation is pending.
Any platform specific information?
Observed on Arista-7280DR3AM-36 with Cloud Light 7123-G37-01 transceivers. The change relies on the existing generic
LPMODE_SKIP_LISTrather than hard-coding a platform.Supported testbed topology if it's a new test case?
Not a new test case. The failure was reproduced on
t2_single_node_max.Documentation
N/A