Conversation
BGP monitor setup in test_bgpmon and the traffic-shift fixture used the global router_mac, which may differ from the egress MAC on per-port MAC platforms and prevent the BGP session from establishing. Use the captured SYN source MAC in test_bgpmon and the selected L3 interface MAC in bgpmon_setup_teardown. Signed-off-by: micasyang <227086378+micasyang@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
micasyang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Collaborator
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix BGP monitor sessions on platforms using per-port MAC addresses.
The global
router_macmay differ from the MAC used by the selectedDUT interface, causing ExaBGP response traffic to use an incorrect
destination MAC.
Type of change
Back port request
N/A — this PR directly targets the 202603 branch.
Approach
What is the motivation for this PR?
The following tests fail because the BGP monitor session cannot be
established:
bgp/test_bgpmon.py::test_bgpmonbgp/test_traffic_shift.py::test_load_minigraph_with_traffic_shift_awayObserved error:
BGP monitor session is not establishedHow did you do it?
test_bgpmon.How did you verify/test it?
Before the fix, both failures were reproduced on a physical c0 testbed.
After the fix, both affected tests passed on a physical c0 testbed.
Any platform specific information?
This issue affects platforms using per-port MAC addresses.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A