[action] [PR:27569] [BMC] Skip fdb/test_fdb_mac_move.py on BMC topology - #1417
Merged
Merged
Conversation
### Description of PR
Summary:
On `bmc` topology testbeds, `tests/fdb/test_fdb_mac_move.py` is the only fdb testfile that runs (it is marked `topology('any')`; the rest of the suite skips via `t0`/`m0`/`mx` topology marks or runtime VLAN checks), and all of its tests fail because the BMC has no switching ASIC, front-panel ports, or VLAN configuration (`KeyError: 'VLAN'` / "DUT has no VLAN/VLAN_MEMBER configuration"). FDB/MAC-move is a switching-ASIC function, so these tests are not applicable on BMC and should be skipped.
### Type of change
- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
- [ ] Skipped for non-supported platforms
- [x] Test case improvement
### Back port request
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511
- [ ] 202512
- [ ] 202605
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
### Tested branch
- [x] master
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [ ] 202511
- [ ] 202512
- [ ] 202605
- [ ] N/A
### Test result
- master: verified on a SONiC BMC testbed — with this change the `test_fdb_mac_move.py` testcases are skipped.
### Approach
#### What is the motivation for this PR?
The fdb suite fails on SONiC BMC testbeds: the three tests in `test_fdb_mac_move.py` run on `bmc` topology and fail, since the BMC has no switching ASIC or VLAN configuration to exercise MAC learning and MAC move.
#### How did you do it?
Added a file-level entry to `tests/common/plugins/conditional_mark/tests_mark_conditions.yaml` skipping `fdb/test_fdb_mac_move.py` when `'bmc' in topo_type`, with reason "FDB tests require switching ASIC, not available on BMC".
#### How did you verify/test it?
- Ran the fdb suite on a SONiC BMC testbed: the `test_fdb_mac_move.py` testcases are skipped with this change.
#### Any platform specific information?
Applies only to `bmc` topology testbeds. No effect on switch platforms or virtual switch (the existing per-test `vs` skip entries still apply).
#### Supported testbed topology if it's a new test case?
N/A
### Documentation
N/A
Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#27569 |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
Author
|
/azp run |
1 similar comment
Collaborator
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
21 tasks
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
On
bmctopology testbeds,tests/fdb/test_fdb_mac_move.pyis the only fdb testfile that runs (it is markedtopology('any'); the rest of the suite skips viat0/m0/mxtopology marks or runtime VLAN checks), and all of its tests fail because the BMC has no switching ASIC, front-panel ports, or VLAN configuration (KeyError: 'VLAN'/ "DUT has no VLAN/VLAN_MEMBER configuration"). FDB/MAC-move is a switching-ASIC function, so these tests are not applicable on BMC and should be skipped.Type of change
Back port request
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
test_fdb_mac_move.pytestcases are skipped.Approach
What is the motivation for this PR?
The fdb suite fails on SONiC BMC testbeds: the three tests in
test_fdb_mac_move.pyrun onbmctopology and fail, since the BMC has no switching ASIC or VLAN configuration to exercise MAC learning and MAC move.How did you do it?
Added a file-level entry to
tests/common/plugins/conditional_mark/tests_mark_conditions.yamlskippingfdb/test_fdb_mac_move.pywhen'bmc' in topo_type, with reason "FDB tests require switching ASIC, not available on BMC".How did you verify/test it?
test_fdb_mac_move.pytestcases are skipped with this change.Any platform specific information?
Applies only to
bmctopology testbeds. No effect on switch platforms or virtual switch (the existing per-testvsskip entries still apply).Supported testbed topology if it's a new test case?
N/A
Documentation
N/A
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com