Enable ACL resource consume scenario#1182
Open
realsdx wants to merge 12 commits into
Open
Conversation
realsdx
changed the title
realsdx
requested review from
alyssa1303,
anson627 and
sumanthreddy29
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Enables a new perf-eval scenario (acl-resource-consume) intended to validate AKS node performance using Azure Container Linux (ACL), and wires it into an Azure DevOps pipeline. The PR also updates the pinned aks-preview Azure CLI extension version used by the Terraform AKS CLI module.
Changes:
- Add Terraform inputs and test inputs for the new
acl-resource-consumescenario (Azure). - Add documentation and an Azure DevOps pipeline YAML to run the scenario via the existing
competitive-testjob template. - Bump the default pinned
aks-previewextension version used bymodules/terraform/azure/aks-cli.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scenarios/perf-eval/acl-resource-consume/terraform-test-inputs/azure.json | Adds minimal Terraform validation JSON inputs for the new scenario (run_id/region). |
| scenarios/perf-eval/acl-resource-consume/terraform-inputs/azure.tfvars | Defines AKS provisioning via the AKS CLI Terraform path, targeting AzureContainerLinux and CRI resource-consume labeling/taints. |
| scenarios/perf-eval/acl-resource-consume/README.md | Documents how to register/queue the pipeline and what ADO inputs/permissions are required. |
| pipelines/perf-eval/CRI Benchmark/acl-resource-consume.yml | Adds an Azure DevOps pipeline to run the scenario using clusterloader2 with the cri-resource-consume topology. |
| modules/terraform/azure/aks-cli/main.tf | Updates the pinned aks-preview Azure CLI extension version used during AKS CLI provisioning. |
Comment on lines
+44
to
+52
| name = "userpool0" | ||
| node_count = 10 | ||
| vm_size = "Standard_D16ds_v6" | ||
| optional_parameters = [ | ||
| { | ||
| name = "node-osdisk-type" | ||
| value = "Ephemeral" | ||
| }, | ||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable ACL resource consume scenario for new ACL distro
This PR also bumps the pinned aks-preview extension version, for newer ACL ossku tag