ci: declare workflow-level contents: read on python and yaml validation#1193
Closed
arpitjain099 wants to merge 1 commit into
Closed
ci: declare workflow-level contents: read on python and yaml validation#1193arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Workflow runs checks only; no GitHub API writes from the workflow itself. Post-CVE-2025-30066 hardening pattern. yaml.safe_load validated. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
requested review from
alyssa1303,
anson627,
liyu-ma,
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR tightens GitHub Actions workflow permissions by explicitly setting read-only repository contents access.
Changes:
- Added
permissions: contents: readto the YAML validation workflow. - Added
permissions: contents: readto the Python validation workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/yaml-validation.yml | Explicitly limits workflow token to read-only contents access. |
| .github/workflows/python-validation.yml | Explicitly limits workflow token to read-only contents access. |
Author
|
Dedup catch on my end: superseded by #1176. Closing, apologies for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENtocontents: readat the workflow level. The workflow runs checks only; no GitHub API writes.Same post-CVE-2025-30066 (
tj-actions/changed-files) supply-chain hardening pattern. YAML validated locally withyaml.safe_load.