feat: extend NodePool schema and CreateResourceGroup with optional fields#1196
Open
xinWeiWei24 wants to merge 1 commit into
Open
feat: extend NodePool schema and CreateResourceGroup with optional fields#1196xinWeiWei24 wants to merge 1 commit into
xinWeiWei24 wants to merge 1 commit into
Conversation
…ields Add vnetSubnetId and osSKU optional fields to NodePool schema, and tags optional parameter to CreateResourceGroup. Both default to empty/omitted for backwards compatibility with existing pipelines. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
xinWeiWei24
requested review from
liyu-ma,
vittoriasalim and
wonderyl
as code owners
liyu-ma
reviewed
May 28, 2026
| count: int | ||
| taintPrefix: str = "" | ||
| labels: str = "" | ||
| vnetSubnetId: str = "" |
Collaborator
There was a problem hiding this comment.
Is it better use str? type which has a default value None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add vnetSubnetId and osSKU optional fields to NodePool schema, and tags optional parameter to CreateResourceGroup. Both default to empty/omitted for backwards compatibility with existing pipelines.