Skip to content

feat: add identity and role assignment lib steps #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xinWeiWei24 wants to merge 3 commits into
base: v2
Choose a base branch
from
Open

feat: add identity and role assignment lib steps #1197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c08f69f
[feat] add identity and role assignment lib steps
xinWeiWei24 May 27, 2026
b1aa77e
add assignee to log
xinWeiWei24 May 28, 2026
90e461e
call az once in identity id checking and add customization for export…
xinWeiWei24 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions kcl/lib/steps/azure/identity.k
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import azure_pipelines.ap.steps

CreateManagedIdentity = lambda serviceConnection: str, subscription: str, resourceGroup: str, name: str, exportVar: str = "IDENTITY" -> steps.Step {
Copy link
Copy Markdown
Collaborator

@wonderyl wonderyl May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, you always need to create managed identity, then assign role, then bind it to a service account. Does it make sense to encapsulate the 3 steps into one?

Copy link
Copy Markdown
Collaborator Author

@xinWeiWei24 xinWeiWei24 May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for my case. I’m not binding it to a service account, and the role assignments target different resources and roles.

script = """
az identity create \\
--resource-group "${resourceGroup}" \\
--name "${name}" \\
--subscription "${subscription}"

IDENTITY=$(az identity show \\
--resource-group "${resourceGroup}" \\
--name "${name}" \\
--subscription "${subscription}")
echo "##vso[task.setvariable variable=${exportVar}_CLIENT_ID]$(echo "$IDENTITY" | jq -r '.clientId')"
echo "##vso[task.setvariable variable=${exportVar}_ID]$(echo "$IDENTITY" | jq -r '.id')"
"""
AzCli(serviceConnection, "Create managed identity ${name}", script)
}
12 changes: 12 additions & 0 deletions kcl/lib/steps/azure/role_assignment.k
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import azure_pipelines.ap.steps

CreateRoleAssignment = lambda serviceConnection: str, scope: str, role: str, assignee: str, subscription: str -> steps.Step {
Copy link
Copy Markdown
Collaborator

@wonderyl wonderyl May 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function doesn't provide much value, would it be easier if the user just call AzCli with the script directly?

Copy link
Copy Markdown
Collaborator

@wonderyl wonderyl May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When create a function, ask yourself, what does this function encapsulate?

Copy link
Copy Markdown
Collaborator Author

@xinWeiWei24 xinWeiWei24 May 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended to be invoked multiple times, since the 3 input variables ( scope, role, assignee) can differ per call. Wrapping it as a function avoids duplicating the same CLI script logic.

script = """
az role assignment create \\
--scope "${scope}" \\
--role "${role}" \\
--assignee "${assignee}" \\
--subscription "${subscription}"
"""
AzCli(serviceConnection, "Assign role ${role} to ${assignee}", script)
}