setup new pipeline to run kubelet config#592
Open
bravebeaver wants to merge 19 commits into
Open
Conversation
…rt with. - the variables are defined to be used by later steps in the pipeline to config cluster accordingly
bravebeaver
requested review from
alyssa1303,
anson627,
rafael-mendes-pereira and
sumanthreddy29
as code owners
alyssa1303
reviewed
Apr 10, 2025
Collaborator
alyssa1303
left a comment
alyssa1303
left a comment
There was a problem hiding this comment.
please add code change to run test first and move the variable setup to matrix
1. Add support for ARM Template deployment. 2. Onboard API server test with Streaming enabled
Member
Author
can i please have another review? added configuration files and the steps to configure clusters. |
alyssa1303
reviewed
May 2, 2025
| - stage: azure_swedencentral_evict_memory_100mi | ||
| dependsOn: [] | ||
| jobs: | ||
| - job: SetKubeletVariables |
Collaborator
There was a problem hiding this comment.
Let's schedule a meeting to go over this PR. An extra job is expensive and should be avoid unless really necessary. Also, I still don't see terraform files? Can you split this PR into smaller one for easier review?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a new pipeline for kubelet eval.
setup extra variables which allows for customised kubelet config later on.