Update Autoscaler Warmup deployment path#607
Merged
Merged
Conversation
f672fdf to
449b42c
Compare
anson627
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
autoscale.pyscript and its associated configuration to support a configurable directory for ClusterLoader2 (CL2) configuration files. The changes ensure that paths to configuration files are dynamically determined based on a newcl2_config_dirparameter, improving flexibility and usability.Updates to
autoscale.py:Parameterization of CL2 configuration directory:
warmup_deployment_for_karpeneterandcleanup_warmup_deployment_for_karpeneterto acceptcl2_config_diras a parameter, replacing hardcoded paths to the warmup deployment file.calculate_cpu_request_for_clusterloader2andoverride_config_clusterloader2to includecl2_config_diras an argument, ensuring all related functions use the configurable directory. [1] [2]cl2_config_dir, to themainfunction for specifying the CL2 configuration directory.Integration with the
mainfunction:override_config_clusterloader2in themainfunction to pass the newcl2_config_dirargument.Updates to
execute.yml:steps/engine/clusterloader2/autoscale/execute.ymlfile to pass theCL2_CONFIG_DIRenvironment variable as thecl2_config_dirparameter when invoking theoverridecommand.This pull request updates the file paths in theautoscale.pyscript to reflect a new directory structure for deployment configuration files.Path updates for deployment files:
warmup_deployment_for_karpeneterandcleanup_warmup_deployment_for_karpeneterfunctions, thedeployment_filepath was updated from"autoscale/config/warmup_deployment.yaml"to"clusterloader2/autoscale/config/warmup_deployment.yaml", ensuring compatibility with the updated directory structure.