Add functionality to scrape kubelets metrics and capture npm metrics in case of network test #610
Merged
Merged
Conversation
Author
anson627
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to scrape kubelet metrics as part of the clusterloader2 SLO configuration and execution. The changes include updates to configuration files, Python scripts, and pipeline definitions to support this new functionality. Here's a breakdown of the most important changes:
Configuration Enhancements:
Added a new parameter
CL2_SCRAPE_KUBELETSinload-config.yamlto enable or disable scraping kubelet metrics. Conditional logic was added to include kubelet metrics modules during the "start" and "gather" phases. [1] [2] [3]Introduced a new module
npm-measurements.yamlfor Azure NPM metrics, which includes Prometheus queries for CPU and memory usage (average and maximum) at different percentiles (P99, P90, P50).Python Script Updates:
Updated the
configure_clusterloader2andexecute_clusterloader2functions inslo.pyto handle the newscrape_kubeletsparameter. This includes writing the parameter to the configuration file and passing it to the clusterloader2 execution command. [1] [2] [3]Modified the
main()function inslo.pyto acceptscrape_kubeletsas an argument for both the "configure" and "execute" commands, ensuring the parameter is properly parsed and passed. [1] [2] [3]Pipeline and Step Updates:
Updated the
network-churnpipeline YAML to setscrape_kubeletstoTruefor relevant stages.Adjusted the
execute.ymlstep script to include theSCRAPE_KUBELETSenvironment variable when invoking the Python script for configuration and execution.