Skip to content

Extend arm-resource-patch rule with PATCH body schema diagnostics #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Extend arm-resource-patch rule with PATCH body schema diagnostics #4381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2594b36
Extend arm-resource-patch with PATCH body schema diagnostics
Copilot May 5, 2026
2a201ba
Merge remote-tracking branch 'origin/main' into copilot/add-arm-patch…
May 5, 2026
624b73c
Allow read-only-only properties in PATCH body; merge main; suppress n…
Copilot May 5, 2026
8c9ed97
Recursive notUpdateableInPatch with per-iteration cycle state; allow …
Copilot May 6, 2026
8adee3a
Merge branch 'main' into copilot/add-arm-patch-body-schema-rule
markcowl May 7, 2026
6cc6f5e
Merge remote-tracking branch 'origin/main' into copilot/add-arm-patch…
Copilot May 8, 2026
02eff57
Use positive Create+Update OR Read-only allowlist; add codefix and de…
Copilot May 8, 2026
ff184b4
Merge remote-tracking branch 'origin/main' into copilot/add-arm-patch…
Copilot May 8, 2026
5c78f64
Use hasVisibility(Update) || (hasVisibility(Read) && !hasVisibility(C…
Copilot May 8, 2026
386446a
Simplify isAllowedInPatchByVisibility to hasVisibility(Update) || isR…
Copilot May 8, 2026
f24ea70
Merge branch 'main' into copilot/add-arm-patch-body-schema-rule
markcowl May 11, 2026
e2a8f3b
Merge remote-tracking branch 'origin/main' into copilot/add-arm-patch…
Copilot May 13, 2026
8107e3d
Address review feedback: shorter messages, content-type variable, rem…
Copilot May 13, 2026
7f8ff8b
Rename isReadOnlyOnly to isReadOnly and readOnlyOnlyCache to readOnly…
Copilot May 13, 2026
e40d942
Merge remote-tracking branch 'origin/main' into copilot/add-arm-patch…
Copilot May 13, 2026
938e57c
Add test: tracked resource 'properties' as optional in PATCH body is …
Copilot May 13, 2026
a78fbc6
Merge branch 'main' into copilot/add-arm-patch-body-schema-rule
markcowl May 20, 2026
a2bb5d6
Use fully-qualified names as cache keys in arm-resource-patch recursion
Copilot May 20, 2026
c73f36d
Merge branch 'main' into copilot/add-arm-patch-body-schema-rule
markcowl May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .chronus/changes/arm-patch-body-schema-2026-05-05-02-30-00.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
changeKind: feature
packages:
- "@azure-tools/typespec-azure-resource-manager"
---

Extend the `arm-resource-patch` linter rule to validate PATCH request body schemas. New diagnostics are emitted when:

- A PATCH request body property is required and not read-only.
- A PATCH request body property has a default value (defaults are never applied to PATCH requests).
- A PATCH request body property is not updateable and not read-only.
- A PATCH operation specifies an explicit `content-type` other than `application/merge-patch+json` (or the implicit `application/json`).

Codefixes are provided to remove default values, mark properties as optional, and remove non-updateable properties from PATCH bodies.
Loading
Loading