Skip to content

Separate media-kit publication from profile picture selection - #364

Merged
BASIC-BIT merged 30 commits into
mainfrom
codex/media-kit-publication
Oct 13, 2026
Merged

BASIC-BIT merged 30 commits into
mainfrom
codex/media-kit-publication

Conversation

@BASIC-BIT

@BASIC-BIT BASIC-BIT commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

[AGENT] Media contributions now publish to the media kit. Selecting a profile picture is a separate action. Contributor-requested replacements reuse the published asset and require independent review. The website checklist is removed, and MCP exposes matching contribution inspection, correction, removal and placement commands.

Existing pictures, historical receipts and stored media are preserved. The bounded migration defaults to dry-run, and the explicit Karly correction requires unchanged asset, placement and selection evidence. Deployment and production conversion are separate operator steps.

Validation: task-scoped implementer/reviewer rounds; backend, contracts, MCP, web, generated-code and markdown checks; desktop/mobile fixture screenshots. The authenticated exact-head staging lifecycle passed for 4aca25eab443d5b007a7370b7052304ec66c0f6b in run 38456308026. All 13 stages passed, including minted direct upload, website/MCP publication and management, distinct assigned-reviewer approval/rejection and replacement, stale/revoked command refusals, expired upload replay refusal and verified cleanup. Staging intake was restored to its paused baseline afterward.

Review limitations: Claude stopped before inference at its configured 500,000-byte PR-input limit, and Copilot could not review because of its quota. The latest GitHub Codex review covers 0959c3a; the final test-only credit assertion change at 4aca25e passed independent scoped review. These are not Claude or Copilot approvals.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:19:26.928821Z 0959c3a New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

[AGENT]

Claude Review

Claude review for commit 4aca25eab443d5b007a7370b7052304ec66c0f6b is unavailable because the pull request was merged.

This is not a current review or approval.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9d5fe1e74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/e2e/media-contribution.flow.spec.ts
Comment thread convex/_mediaContributionCommands.ts
Comment thread apps/web/src/lib/server/vrdex-mcp.ts
Comment thread convex/_profileAssets.ts Outdated
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

PR verification report

All configured preview and verification checks passed.

Check Result Evidence
Mutation data flow PASSED Open artifact
Hosted data flow PASSED Open artifact
Public route screenshots PASSED Open artifact
Public route image diff PASSED Open artifact
Storybook screenshots PASSED Open artifact
Storybook image diff PASSED Open artifact

Changed visual baselines: none.

Updated from Baseline Checks run 38454370541, attempt 1 for 4aca25e. This comment is updated in place.

@BASIC-BIT

Copy link
Copy Markdown
Owner Author

[AGENT] Claude capability finding addressed in b3b4b37 using the shared publicKitAvailable predicate and submission gate. New disabled-gate regressions preserve historical receipt recovery. Independent review passed. The corresponding Codex thread was replied to and resolved before this push. The docs build and two upload findings are also fixed and independently reviewed; authenticated staging acceptance is being rerun.

Copilot AI balanced review requested due to automatic review settings October 6, 2026 15:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b89889f60d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread convex/_mediaContributionCommands.ts
Comment thread apps/web/src/app/_components/profile-public-page.tsx Outdated
Copilot AI balanced review requested due to automatic review settings October 13, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cebb456ee9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread convex/_mediaContributionCommands.ts
Comment thread convex/mediaKitPublicationMigration.ts Outdated
Comment thread convex/profileMediaSubmissions.ts Outdated
Comment thread convex/_mediaContributionCommands.ts Outdated
Comment thread convex/_mediaReview.ts Outdated
@BASIC-BIT

Copy link
Copy Markdown
Owner Author

[AGENT] Claude empty-slot replacement finding and the related Codex feedback are fixed in 4702c5d, independently reviewed. Empty replacement admission/approval is refused, inherited scoped reviewer queues route to new proposal IDs, migration provenance survives completion, and restriction/read boundaries are bounded. The failed staged RPC proposal timing defect is reproduced locally and the fixture now waits for the existing cooldown; exact-head hosted verification will rerun. Direct unbatched ordinary-reviewer assignment remains a follow-up, with the existing distinct-admin route preserved.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4702c5d636

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/app/account/media-contributions/publication-card.tsx Outdated
Comment thread convex/_mediaContributionCommands.ts Outdated
Comment thread convex/_mediaContributionCommands.ts
Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 786fa60d65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread convex/mediaKitPublicationMigration.ts
Comment thread scripts/media-kit-publication-migration.mjs
Comment thread convex/mediaKitPublicationMigration.ts Outdated
Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fec2860fa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/app/_components/profile-public-page.tsx
Comment thread convex/profileMediaSubmissions.ts Outdated
Comment thread convex/_mediaReview.ts
Comment thread packages/api-contracts/src/media-review.ts Outdated
Copilot AI balanced review requested due to automatic review settings October 13, 2026 19:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread tests/backend/profile-assets-management.test.ts Fixed
Copilot AI balanced review requested due to automatic review settings October 13, 2026 19:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@BASIC-BIT
BASIC-BIT merged commit ee141cd into main Oct 13, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants