Skip to content

[AGENT] Refine event editor wizard and optional end times - #365

Merged
BASIC-BIT merged 15 commits into
mainfrom
codex/event-editor-wizard-refinement
Oct 13, 2026
Merged

BASIC-BIT merged 15 commits into
mainfrom
codex/event-editor-wizard-refinement

Conversation

@BASIC-BIT

@BASIC-BIT BASIC-BIT commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

[AGENT] The event editor now starts with Details and a three-step wizard. A compact Import poster or text action opens the optional source dialog. Community selection uses directory search, Starts and optional Ends use native combined controls, and Time TBA retains reversible edits within the open contributor editor.

Staff editing preserves exact stored end times and leaves an unknown end unset. Discovery and live status use the existing six-hour runtime fallback for no-end events. Explicit ends keep their authored boundary. Discovery uses bounded candidate scans, with capacity-related omissions documented.

Imported times retain their calendar dates across acceptance order and draft save/resume. Times accepted under Time TBA restore when it is switched off. Continue advances through incomplete steps; Publish still validates and focuses invalid fields.

Validation covers correction payloads, partial/date-only drafts, overnight dates, DST gaps/folds, exact staff timestamps, import acceptance, runtime boundaries and candidate limits. Desktop/mobile Linux Chromium screenshots cover both themes. Fixture tests do not establish production authentication or live extraction accuracy. Import remains on contributor drafts; native calendar appearance varies by platform.

Visual evidence: desktop staff Details, mobile staff Details.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 12:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T14:13:32.536594Z 77146a3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9cb305a03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/lib/calendar/event-end-time.ts
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

[AGENT]

Claude Review

Claude review for commit 77146a33b49c4f545d569f454b5e32be04439eed is unavailable because the pull request was merged.

This is not a current review or approval.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 3/5

[Medium impact] Refines the event editor wizard UI and adds optional end times.

Fix the two suggestion-acceptance problems before merging #365.

Findings

  1. P1 Acceptance order changes event dates ▶
  2. P1 Accepted time suggestions disappear ▶
  3. P2 Continue checks other steps ▶
Fix with agent prompt
### Issue 1
apps/web/src/app/events/event-intake-form.tsx:158-160
Accepting an extracted end before its suggested date now keeps the end on the old date. With `eventDate` October 10 and extracted October 11 times, accepting the end first and then Date makes `receiveFields` rebase that end to October 10. Accepting Date first produces October 11 instead. Accepted lineup times have the same problem. This can block publication or save the wrong schedule.

Keep suggested times tied to their suggested date so acceptance order does not change the schedule.

### Issue 2
apps/web/src/app/events/event-intake-form.tsx:163
Accepting a time suggestion while Time TBA is checked silently discards it. `receiveFields` clears the accepted time through `untimed`, while the Accept button removes it from `tentative`. Turning Time TBA off then restores the old `timedBackup`, not the accepted value. Contributors lose their accepted suggestion and can get older times back instead.

Either disable time acceptance while Time TBA is checked or keep accepted times in the backup for later restoration.

### Issue 3
apps/web/src/app/events/event-intake-form.tsx:276
Making Continue submit the contributor form makes navigation check every mounted field. A blank performer or invalid Source URL in a hidden step can stop Continue and send the user to that field instead of the next step. Direct step buttons still bypass those checks, so contributors must fix fields early or use those buttons to navigate an incomplete draft.

Add `formNoValidate` to Continue so it advances without weakening the checks on Publish.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR starts event editing at Details and uses three steps. Contributor drafts get an optional import dialog and community search. Staff editing gains optional ends without inventing a duration.

  • Event contributors start with Details and import sources separately.
  • Contributor time fields combine the date and clock time.
  • Staff can set, clear, or preserve an event’s end time.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Details <--> Lineup
  Lineup <--> Review
  Details --> Import[Optional contributor import]
  Lineup --> Import
  Review --> Import
  Import --> Suggestions[Extracted suggestions]
  Suggestions --> Details
  Review --> Save[Save or publish]
  Staff[Staff Details] --> Ends[Stored, entered, or lineup end]
  Ends --> Save
Loading

Reviews (1) · Last reviewed commit: "Keep keyboard-active community visible i..." · Reviewed by Greptile

Comment thread apps/web/src/app/events/event-intake-form.tsx
Comment thread apps/web/src/app/events/event-intake-form.tsx
Comment thread apps/web/src/app/events/event-intake-form.tsx Outdated
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

PR verification report

All configured preview and verification checks passed.

Check Result Evidence
Mutation data flow PASSED Open artifact
Hosted data flow PASSED Open artifact
Public route screenshots PASSED Open artifact
Public route image diff PASSED Open artifact
Storybook screenshots PASSED Open artifact
Storybook image diff PASSED Open artifact
Changed visual baselines (14)
desktop-chromium / event-editor-create-details
desktop-chromium / event-editor-create-details
desktop-chromium / event-editor-create-lineup
desktop-chromium / event-editor-create-lineup
desktop-chromium / event-editor-create-review
desktop-chromium / event-editor-create-review
desktop-chromium / event-editor-edit-details
desktop-chromium / event-editor-edit-details
desktop-chromium / event-editor-edit-lineup
desktop-chromium / event-editor-edit-lineup
desktop-chromium / event-editor-edit-review
desktop-chromium / event-editor-edit-review
desktop-chromium / event-lineup-editor
desktop-chromium / event-lineup-editor
mobile-chromium / event-editor-create-details
mobile-chromium / event-editor-create-details
mobile-chromium / event-editor-create-lineup
mobile-chromium / event-editor-create-lineup
mobile-chromium / event-editor-create-review
mobile-chromium / event-editor-create-review
mobile-chromium / event-editor-edit-details
mobile-chromium / event-editor-edit-details
mobile-chromium / event-editor-edit-lineup
mobile-chromium / event-editor-edit-lineup
mobile-chromium / event-editor-edit-review
mobile-chromium / event-editor-edit-review
mobile-chromium / event-lineup-editor
mobile-chromium / event-lineup-editor

Updated from Baseline Checks run 38410819046, attempt 1 for 77146a3. This comment is updated in place.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 13:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copy link
Copy Markdown
Owner Author

[AGENT] @codex review

Please review current head 5e783d6, including the no-end runtime and contributor acceptance fixes. All four original findings have replies and are resolved. The two missed editor baselines were refreshed after inspecting desktop/mobile actuals and diffs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e783d6cde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread convex/_worldEvents.ts Outdated
Copilot AI balanced review requested due to automatic review settings October 13, 2026 13:37

Copy link
Copy Markdown
Owner Author

[AGENT] @codex review

Current head is 8152e14. The duplicate world-association hydration finding is fixed, replied to and resolved. Backend CI fixtures now model valid schedules, and the generated declaration matches CI output. Independent scoped review and the exact-head full backend suite passed.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8152e145d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread convex/_eventPublic.ts
Comment thread convex/_searchDocuments.ts
Copilot AI balanced review requested due to automatic review settings October 13, 2026 14:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copy link
Copy Markdown
Owner Author

[AGENT] @codex review

Current head is 77146a3. Both remaining findings are fixed, replied to and resolved. Person queries skip expired cached history before hydration, and bounded generic search scores live event schedules before limits while keeping community/profile hydration lazy. Fresh scoped review and all 1,269 backend tests passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 77146a33b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BASIC-BIT
BASIC-BIT merged commit 2886542 into main Oct 13, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants