Repository navigation
[AGENT] Make visual evidence opt-in while retaining browser assertions - #369
Conversation
PR verification reportAll configured preview and verification checks passed. Visuals selected for this run: yes.
Changed visual baselines: none. Updated from Baseline Checks run 38680043293, attempt 1 for |
BASIC-BIT
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
 [High impact] The PR appears safe to merge; no actionable defects were found. SummaryMakes review screenshots and both image-comparison suites opt-in through
The previous and current heads have different merge bases with the target commit, so this review covered the full PR diff. No new actionable issues were found. Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Normal PR event] --> Selection{ci:visuals present?}
PR --> Smoke[Public smoke and data-flow assertions]
Selection -->|No| Assertions[Preview assertions without review screenshots]
Selection -->|Yes| Captures[Preview assertions with review screenshots]
Selection -->|Yes| Comparisons[Both image comparisons]
Smoke --> Report[Check results and required artifacts]
Assertions --> Report
Captures --> Report
Comparisons --> Report
Report --> Head{Current PR head?}
Head -->|Yes| Publish[Update report with run selection]
Head -->|No| Ignore[Do not publish]
Removal[Label removed] --> Historical[Preserve results and mark visuals historical]
Reviews (2) · Last reviewed commit: "Merge main HMR correction into optional ..." · Reviewed by Greptile |
|
[AGENT] Claude ReviewClaude review for commit This is not a current review or approval. |
|
[AGENT] Re the non-blocking coverage observation in the Claude review: the label-change publication path was exercised in the real default run. I added |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
[AGENT]
Keep browser assertions automatic while making review screenshots and both Linux image comparisons opt-in with
ci:visuals. Selection applies on normal PR events, regardless of changed paths. Label edits do not launch the app pipeline; local capture behavior stays unchanged unless explicitly disabled.The consolidated report fails on missing required evidence, invalid selection, or failed/cancelled/unexpectedly skipped comparisons. It rejects stale heads and invalidates prior visual claims when the label is removed. Baselines are never updated automatically.
The newly automatic public smoke suite exposed two stale expectations. Tests now verify the existing community-scoped event image route and accessible keyboard selection, preserving image-content, focus and Enter-navigation assertions.
The branch includes main
104dad4efrom merged PR #368, preserving its HMR correction and the optional capture guard. The event-editor snapshot spec and baselines match main.Validation on
d65048d2:ci:visualsduring the default run launched no app pipeline. Its report preserved the original selection and noted the later label change. The ready-for-review event selected both comparisons on the same commit.