Repository navigation
fix: resolve current VRChat icons with file provenance - #371
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
[Medium impact] The PR appears safe to merge: #371. SummaryAdds automatic pictures for current VRChat
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Read VRChat user] --> B{Allowed userIcon?}
B -->|Yes| C[Return legacy icon]
B -->|No| D{Supported iconUrl reference?}
D -->|No| E[Return name without artwork]
D -->|Yes| F[Reserve budget and read file]
F --> G{Identity, owner, purpose and version match?}
G -->|Yes| H[Return verified user_icon]
G -->|No| E
F -->|Temporary failure| I[Keep cached result]
F -->|Authentication or rate limit| J[Use existing account handling]
Reviews (1) · Last reviewed commit: "fix: resolve current VRChat icons with f..." · Reviewed by Greptile |
|
[AGENT] Claude ReviewClaude review for commit This is not a current review or approval. |
PR verification reportAll configured preview and verification checks passed. Visuals selected for this run: no (assertions only).
Changed visual baselines: none. Updated from Baseline Checks run 38685227349, attempt 1 for |
[AGENT] Current VRChat user responses can return
iconUrlwithoutuserIcon, so the collector resolves a person's name but drops their automatic picture. Accept the current response only after a budgeted exact-file lookup confirms its identity, owner,iconpurpose, and complete referenced version. Preserve explicit legacy icons and the existing artwork result contract.The regression reproduces the observed response through the real HTTP client and collector job. Coverage rejects avatar-purpose, foreign, incomplete, and ambiguous files, and checks the second request's budget, authentication, and rate-limit handling. Updated the behavior and collector docs.
Validation: 182 collector tests, 18 backend destination/fallback/projection tests, 13 artwork/cache tests, backend typecheck, and Markdown lint passed. Independent source review found no actionable defects.
Deployment and cache refresh are separate. Collector-account file visibility and default/migrated icon behavior still need runtime verification before refreshing affected production rows.