[Campus][Feature] 분실물 게시글 수정 기능 구현 #1241

KYM-P · 2026-01-23T07:10:51Z

PR 개요

이슈 번호: #1214

PR 체크리스트

Code convention을 잘 지켰나요?
Lint check를 수행하였나요?
Assignees를 추가했나요?

작업사항

작업사항의 상세한 설명

분실물 게시글 수정 api 에 잘못된 요청을 수정했습니다.

이미지 삭제 리스트를 List 형태로 바꾸었습니다.
이미지 추가 리스트의 request field name 을 new_images 로 수정했습니다.

분실물 작성 에서의 ui component 를 공용 component 로 이동했습니다.

작성, 수정에서 동시에 사용하기에 write 가 아닌 edit 으로 명칭을 변경한 후 공용 component 로 수정했습니다.

분실물 수정 기능을 추가했습니다.

분실물 수정은 분실물이 not found 상태에서만 가능합니다.
uploadImage 를 신규 usecase 로 대체했습니다.

논의 사항

스크린샷

추가내용

develop, sprint 브랜치를 향하고 있습니다
production 브랜치를 향하고 있습니다

…o feature/#1214-lostandfound-edit

…b/KOIN_ANDROID into feature/#1214-lostandfound-edit

…om/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-modify

kongwoojin

고생하셨습니다.
코멘트 확인해주세요

kongwoojin · 2026-01-23T10:10:23Z

...ndfound/src/main/java/in/koreatech/koin/feature/lostandfound/ui/detail/LostAndFoundDetail.kt

+                            onModifyArticleClick = {
+                                navigateToModify(uiState.id)


외부 변수를 사용하고 있으니 메모이제이션 처리를 하면 좋을 것 같습니다

kongwoojin · 2026-01-23T10:12:31Z

...ndfound/src/main/java/in/koreatech/koin/feature/lostandfound/ui/modify/LostAndFoundModify.kt

+                                        val fileType =
+                                            context.contentResolver.getType(uri)
+                                                ?: "image/${fileName.split(".").last()}"


이미지가 아닌 파일을 업로드 시도하는 경우 어떻게 되나요?

fileType.startsWith("image/") 으로 판단해서 image 인 경우만 하도록 하겠습니다.
type 이 null 인 경우는 그냥 무시하는게 나으려나요?

이미지가 아닙니다 같은 처리로 가능할 것 같습니다

nullable 로 바꾸었습니다. null 일 경우 image 로 판단하지 않고 false 로 판단하여 등록되지 않습니다.
등록되지 않으면 toast message 를 올려줍니다.

kongwoojin · 2026-01-23T10:13:26Z

...rc/main/java/in/koreatech/koin/feature/lostandfound/ui/modify/LostAndFoundModifyViewModel.kt

+) : ViewModel(),
+    ContainerHost<LostAndFoundModifyState, LostAndFoundModifySideEffect> {
+    override val container =
+        container<LostAndFoundModifyState, LostAndFoundModifySideEffect>(
+            LostAndFoundModifyState(),
+            savedStateHandle
+        ) {
+            val articleId = savedStateHandle.get<Int>(ARTICLE_ID)
+            checkNotNull(articleId)
+            fetchLostAndFoundDetail(articleId)
+        }
+    private var originImages: List<ArticleLostAndFound.ArticleLostAndFoundImage> = emptyList()


코드 포맷팅이 이상하네요

container 말씀하시는거죠? 일단 container 고치도록 하겠습니다.

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-chore

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-chore

…m/BCSDLab/KOIN_ANDROID into feature/#1214-fetch-lostandfound-v2

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

…/BCSDLab/KOIN_ANDROID into feature/#1214-fetch-lostandfound-v2

…/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

…com/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

[Campus][Feature] 분실물 로깅

…d-v2 [Campus][Feature] 분실물 단일 조회 V2 적용

[Campus][Feature] 분실물 deep link 추가 + 구조 개선

JaeYoung290

수고 많으셨습니다!
코멘트 확인 한번만 부탁드립니다!

JaeYoung290 · 2026-01-25T08:56:49Z

...ndfound/src/main/java/in/koreatech/koin/feature/lostandfound/ui/modify/LostAndFoundModify.kt

+                        isScrolling = isScrolling,
+                        refreshDatePicker = uiState.refreshDatePicker,
+                        onAddImageClick = { uri ->
+                            val cursor = context.contentResolver.query(uri, null, null, null, null)


cursor 사용하는 부분은 viewmodel로 이동하는 건 어떤가요?
이미지 업로드 로직으로 보이는데 이건 비즈니스 로직이라 분리하는 것이 더 좋아 보입니다!

context 객체를 포함하고 있어서 viewmodel에서 사용하긴 부적절해보입니다.

JaeYoung290 · 2026-01-25T09:05:27Z

...ndfound/src/main/java/in/koreatech/koin/feature/lostandfound/ui/modify/LostAndFoundModify.kt

+            EditArticleItemDetail(
+                type = lostOrFoundType,
+                moreDescription = articleData.content ?: "",
+                onMoreDescriptionChange = { onUpdateDescription(it) },


이 부분에서 리컴포지션마다 함수 객체가 새로 생성되면서 unstable하게되지 않나요?

수정되었습니다~

JaeYoung290

수고 많으셨습니다! 다른 의견 없습니다~

This reverts commit d9119a0.

KYM-P added 9 commits January 23, 2026 07:56

Merge branch 'develop' of https://github.com/BCSDLab/KOIN_ANDROID int…

2b8ab86

…o feature/#1214-lostandfound-edit

feature: Change modify deleteImageIds field type to List<Int>

60db1ed

feature: Rename field in lostandfound modify request

d5db673

feature: Add lostandfound modify

22d8f2d

chore: Feat ktlint

bc8b04e

Merge branch 'feature/lostandfound-base' of https://github.com/BCSDLa…

9d06fb4

…b/KOIN_ANDROID into feature/#1214-lostandfound-edit

feature: Delete useless backStackEntry

5924a08

Merge branch 'feature/#1214-lostandfound-modifiy' of https://github.c…

ebf8514

…om/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-modify

feature: Modifty only not found article

e276487

KYM-P requested a review from a team as a code owner January 23, 2026 07:10

github-actions bot added campus BCSD campus ream feature labels Jan 23, 2026

github-actions bot requested review from TTRR1007 and kongwoojin January 23, 2026 07:11

KYM-P self-assigned this Jan 23, 2026

KYM-P added 3 commits January 23, 2026 18:10

feature: LostAndFoundList can refresh

9ed7cac

feature: Add LostAndFounWrite item delete option

85c3a3c

feature: Add koin://article/lost-item link to LostAndFoundActivity

584a281

kongwoojin reviewed Jan 23, 2026

View reviewed changes

KYM-P added 8 commits January 23, 2026 20:32

feature: Navigate lostandfound by deeplink

63ab5ab

chore: Remake LostAndFoundFilterType

0e434ce

feature: Lambda to remember value

7b9ec59

chore: Fix code formatting

ef9f26b

feature: Add image only image type content

e157858

Merge branch 'feature/#1214-lostandfound-modify' of https://github.co…

18fa947

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-chore

feature: fetchLostAndFoundArticleV2

a538fbc

chore: Feat ktlint

88c5024

KYM-P requested a review from kongwoojin January 23, 2026 13:43

KYM-P added 2 commits January 23, 2026 22:44

feature: Add entry log

512fc5f

feature: Add log

5e86723

KYM-P added 17 commits January 23, 2026 23:16

Merge branch 'feature/#1214-lostandfound-modify' of https://github.co…

2834aa6

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

feature: Add log modify

eb3c4b1

feature: Add not image message and type is nullable

c803aec

Merge branch 'feature/#1214-lostandfound-modify' of https://github.co…

4f7a1bb

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-chore

Merge branch 'feature/#1214-lostandfound-modify' of https://github.co…

459bb2d

…m/BCSDLab/KOIN_ANDROID into feature/#1214-fetch-lostandfound-v2

Merge branch 'feature/#1214-lostandfound-modify' of https://github.co…

3702aad

…m/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

chore: Feat ktlint

284a7a3

chore: Feat ktlint

257f523

Merge branch 'feature/#1214-lostandfound-chore' of https://github.com…

bbd1d26

…/BCSDLab/KOIN_ANDROID into feature/#1214-fetch-lostandfound-v2

chore: Feat ktlint

aff5ec1

chore: Feat ktlint

56927a7

Merge branch 'feature/#1214-lostandfound-chore' of https://github.com…

5dc539d

…/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

Merge branch 'feature/#1214-fetch-lostandfound-v2' of https://github.…

368640e

…com/BCSDLab/KOIN_ANDROID into feature/#1214-lostandfound-logging

Merge pull request #1244 from BCSDLab/feature/#1214-lostandfound-logging

2c474c9

[Campus][Feature] 분실물 로깅

Merge pull request #1243 from BCSDLab/feature/#1214-fetch-lostandfoun…

d6b7c7a

…d-v2 [Campus][Feature] 분실물 단일 조회 V2 적용

feature: Detail show created date

f16b972

Merge pull request #1242 from BCSDLab/feature/#1214-lostandfound-chore

15d0101

[Campus][Feature] 분실물 deep link 추가 + 구조 개선

JaeYoung290 reviewed Jan 25, 2026

View reviewed changes

feature: Delete useless lambda

e56583d

JaeYoung290 approved these changes Jan 25, 2026

View reviewed changes

KYM-P added 2 commits January 30, 2026 00:30

feature: First emit drop

d9119a0

Revert "feature: First emit drop"

87b2cca

This reverts commit d9119a0.

[Campus][Feature] 분실물 게시글 수정 기능 구현 #1241

Are you sure you want to change the base?

[Campus][Feature] 분실물 게시글 수정 기능 구현 #1241

Uh oh!

Conversation

KYM-P commented Jan 23, 2026

PR 개요

PR 체크리스트

작업사항

작업사항의 상세한 설명

논의 사항

스크린샷

추가내용

Uh oh!

kongwoojin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KYM-P Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaeYoung290 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaeYoung290 Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JaeYoung290 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

KYM-P Jan 23, 2026 •

edited

Loading

JaeYoung290 left a comment •

edited

Loading

JaeYoung290 Jan 25, 2026 •

edited

Loading