[Feature][Koin Project] 상점 카테고리 캐싱 로직 구현 #1250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KYM-P
approved these changes
Jan 29, 2026
| @Insert(onConflict = OnConflictStrategy.REPLACE) | ||
| suspend fun insert(cacheMetadata: CacheMetadataEntity) | ||
|
|
||
| @Query("SELECT updated_time from ${DBConstant.CACHE_METADATA} where cacheKey = :cacheKey LIMIT 1") |
Collaborator
There was a problem hiding this comment.
FROM, WHERE 같은 sql 문은 대문자로 적는게 좋아보입니다.
| return Room.databaseBuilder( | ||
| context, | ||
| AppDatabase::class.java, | ||
| "koin_database" |
Collaborator
There was a problem hiding this comment.
이것도 constant 로 관리하는건 어떨까요
수정 가능성이 매우 낮긴 하지만요
Member
Author
There was a problem hiding this comment.
이거는 수정 가능성이 제로라 괜찮을 것 같습니다.
| val cachedTime = cacheLocalDataSource.getCachedTime(DBConstant.STORE_CATEGORIES) | ||
| val now = System.currentTimeMillis() | ||
|
|
||
| val cacheShouldExpire = cachedTime == null || (now - cachedTime) > 7 * 24 * 60 * 60 * 1000L |
Collaborator
There was a problem hiding this comment.
kotlin 에 7.days.inWholeMilliseconds 같은 코드나
java 의 TimeUnit.DAYS.toMillis(7) 같은 코드로 7일을 Milli 단위로 변환할 수 있다고 하네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 개요
PR 체크리스트
작업사항
작업사항의 상세한 설명
CacheMetadataDao를 추가했습니다.cacheKey를 활용해서 캐싱된 시간을 저장하시면 됩니다.논의 사항
스크린샷
추가내용