feat: add --target flag to listen only to specific MPRIS services#1
Open
shibahex wants to merge 4 commits intoBEST8OY:mainfrom
Open
feat: add --target flag to listen only to specific MPRIS services#1shibahex wants to merge 4 commits intoBEST8OY:mainfrom
shibahex wants to merge 4 commits intoBEST8OY:mainfrom
Conversation
added logic where users can set the --target (LIST) flag to only listen to certain services this was needed, because If I only want lyrics from spotify, then setting up the block_list is not as dynamic then just setting a target. (also multiple MPRIS services kept breaking the lyrics) same logic as block list, just returns true if target flag is empty.
Author
|
Im making a quickshell module that has karaoke like lyrics in the taskbar, that are animated! love this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the inverse of the existing
--blockflag.Added a --target flag to allow users to filter for specific MPRIS services.
Changes
Previously, users could only block services. This new flag is more of a "whitelist" approach, ensuring the app only listens to preferred players (e.g., Spotify) and preventing conflicts when multiple MPRIS services are active.