Skip to content

fix: restore per-client rate limiting after fastify trustProxy hardening #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BElluu merged 1 commit into from
Sep 8, 2026
Merged

fix: restore per-client rate limiting after fastify trustProxy hardening #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/api/src/config/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@ export function resolveTrustProxy(raw = process.env['TRUST_PROXY']): TrustProxy
const value = raw?.trim()
if (!value || value.toLowerCase() === 'false') return false
if (value.toLowerCase() === 'true') return true
if (/^\d+$/.test(value)) return Number(value)
if (/^\d+$/.test(value)) {
// Hop-count-only trust can't validate the immediate peer, so @fastify/proxy-addr
// no longer supports it (it always fails closed). The only documented deployment
// puts the reverse proxy on the same host, forwarding to loopback, so treat a
// numeric value as "trust the loopback interface" to keep TRUST_PROXY=1 working.
return ['127.0.0.1', '::1']
}
const addresses = value.split(',').map((address) => address.trim()).filter(Boolean)
if (addresses.length === 0) return false
return addresses.length === 1 ? addresses[0]! : addresses
Expand Down
2 changes: 1 addition & 1 deletion apps/api/test/rate-limit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('rate limit isolation and proxy handling', () => {
it('parses explicit trust proxy settings safely', () => {
assert.equal(resolveTrustProxy(''), false)
assert.equal(resolveTrustProxy('false'), false)
assert.equal(resolveTrustProxy('1'), 1)
assert.deepEqual(resolveTrustProxy('1'), ['127.0.0.1', '::1'])
assert.deepEqual(resolveTrustProxy('127.0.0.1, ::1'), ['127.0.0.1', '::1'])
})

Expand Down