Skip to content

Fix/remount segment address #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BGQ99 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/remount segment address #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baa16b4
fix for ub segment
Aug 8, 2026
7e49de1
fix(store): preserve remount validation for unique endpoints
BGQ99 Aug 22, 2026
b599d8b
Merge upstream/main into fix/remount-segment-address
BGQ99 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions mooncake-store/src/master_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,18 +1128,41 @@ auto MasterService::ReMountSegment(const std::vector<Segment>& segments,
.get_memory_descriptor()
.buffer_descriptor;
SegmentRestore* match = nullptr;
SegmentRestore* endpoint_match = nullptr;
size_t endpoint_match_count = 0;
for (auto& restore : restores) {
if (descriptor.transport_endpoint_ ==
restore.segment.te_endpoint ||
descriptor.transport_endpoint_ ==
restore.segment.name) {
endpoint_match = &restore;
++endpoint_match_count;
if (descriptor.buffer_address_ <
restore.segment.base ||
descriptor.buffer_address_ -
restore.segment.base >=
restore.segment.size) {
continue;
}
if (match != nullptr) {
ambiguous_endpoint = true;
return;
}
match = &restore;
}
}
// Preserve endpoint-only matching when it is
// unique so allocator restoration validates
// descriptor bounds. Shared endpoints (e.g.
// UB per-NUMA segments) require one address
// range match to disambiguate the segment.
if (endpoint_match_count == 1) {
match = endpoint_match;
} else if (endpoint_match_count > 1 &&
match == nullptr) {
ambiguous_endpoint = true;
return;
}
if (match != nullptr) {
if (descriptor.protocol_ == "cxl") {
unsupported_cxl = true;
Expand Down
Loading