Skip to content

refactor: use standard Java HTTP status constants#2460

Draft
LarsV123 wants to merge 1 commit intomainfrom
larsv/2026-01-23-refactor-http-codes
Draft

refactor: use standard Java HTTP status constants#2460
LarsV123 wants to merge 1 commit intomainfrom
larsv/2026-01-23-refactor-http-codes

Conversation

@LarsV123
Copy link
Contributor

Replace AWS SDK HttpStatusCode constants with java.net.HttpURLConnection constants for HTTP status codes. This removes an unnecessary dependency on AWS SDK classes for simple HTTP status code values.

Replace AWS SDK HttpStatusCode constants with java.net.HttpURLConnection
constants for HTTP status codes. This removes an unnecessary dependency
on AWS SDK classes for simple HTTP status code values.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

Test Results

  292 files  ±0    292 suites  ±0   23m 31s ⏱️ -30s
9 472 tests ±0  9 461 ✅ ±0  11 💤 ±0  0 ❌ ±0 
9 945 runs  ±0  9 934 ✅ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit b89bdb1. ± Comparison against base commit 521f4a1.

This pull request removes 302 and adds 143 tests. Note that renamed tests count towards both.
            "composer" : "DtePAk2ZjLw8Lzr",
            "day" : "3syDklZHbnBwWUfV5"
            "day" : "rPHYfsH5VIzz"
            "description" : "Some description"
            "extent" : "GuJRYj8fAOMcQPQSMI"
            "formatted" : "M-2306-7118-7"
            "introduction" : {
            "month" : "agqDekENHtR2Gy",
            "month" : "dmslbxWc3hmaUBQiv",
            "name" : "OVuxPTXnSLd7jcg"
…
no.sikt.nva.brage.migration.merger.PublicationInstanceMergerTest ‑ [21] no.unit.nva.model.instancetypes.journal.ProfessionalArticle@bba2f02d
no.sikt.nva.brage.migration.merger.PublicationInstanceMergerTest ‑ [22] no.unit.nva.model.instancetypes.journal.AcademicArticle@fd3147ae
no.unit.nva.LiteraryArtsAudioVisualMigrationTest ‑ [1] {
          "type" : "LiteraryArtsAudioVisual",
          "subtype" : "RadioPlay",
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rYgvX1EuiAFLb"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "hJ9lbyvYn0VvE5oYHw",
            "month" : "agqDekENHtR2Gy",
            "day" : "rPHYfsH5VIzz"
          },
          "isbn" : "9780099470434",
          "extent" : 1040853105
        }
no.unit.nva.LiteraryArtsAudioVisualMigrationTest ‑ [2] {
          "type" : "LiteraryArtsAudioVisual",
          "subtype" : "RadioPlay",
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rYgvX1EuiAFLb"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "hJ9lbyvYn0VvE5oYHw",
            "month" : "agqDekENHtR2Gy",
            "day" : "rPHYfsH5VIzz"
          },
          "isbnList" : [ "9780099470434" ],
          "extent" : 1040853105
        }
no.unit.nva.LiteraryArtsAudioVisualMigrationTest ‑ [3] {
          "type" : "LiteraryArtsAudioVisual",
          "subtype" : "RadioPlay",
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rYgvX1EuiAFLb"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "hJ9lbyvYn0VvE5oYHw",
            "month" : "agqDekENHtR2Gy",
            "day" : "rPHYfsH5VIzz"
          },
          "extent" : 1040853105
        }
no.unit.nva.LiteraryArtsAudioVisualMigrationTest ‑ [4] {
          "type" : "LiteraryArtsAudioVisual",
          "subtype" : {            "type" : "Other",
            "description" : "Some description"
          },
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rYgvX1EuiAFLb"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "hJ9lbyvYn0VvE5oYHw",
            "month" : "agqDekENHtR2Gy",
            "day" : "rPHYfsH5VIzz"
          },
          "extent" : 10408…
no.unit.nva.LiteraryArtsAudioVisualMigrationTest ‑ [5] {
          "type" : "LiteraryArtsAudioVisual",
          "subtype" : {
            "type" : "Other"
          },
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rYgvX1EuiAFLb"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "hJ9lbyvYn0VvE5oYHw",
            "month" : "agqDekENHtR2Gy",
            "day" : "rPHYfsH5VIzz"
          },
          "extent" : 1040853105
        }
no.unit.nva.LiteraryArtsMonographMigrationTest ‑ [1] {
          "type" : "LiteraryArtsMonograph",
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rCmadtTtK1WQtRkPEA"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "tqrJ3RsfZm",
            "month" : "dmslbxWc3hmaUBQiv",
            "day" : "3syDklZHbnBwWUfV5"
          },
          "isbn" : "9780099470434",
          "pages" : {
            "type" : "MonographPages",
            "introduction" : {
        …
no.unit.nva.LiteraryArtsMonographMigrationTest ‑ [2] {
          "type" : "LiteraryArtsMonograph",
          "publisher" : {
            "type" : "UnconfirmedPublisher",
            "name" : "rCmadtTtK1WQtRkPEA"
          },
          "publicationDate" : {
            "type" : "PublicationDate",
            "year" : "tqrJ3RsfZm",
            "month" : "dmslbxWc3hmaUBQiv",
            "day" : "3syDklZHbnBwWUfV5"
          },
          "isbnList" : [ "9780099470434" ],
          "pages" : {
            "type" : "MonographPages",
            "introduction" : {
…
no.unit.nva.LiteraryArtsMonographMigrationTest ‑ [3] {
       "isbnList": [
        "9788234709159"
       ],
       "pages": {
        "illustrated": false,
        "type": "MonographPages"
       },
       "publicationDate": {
        "type": "PublicationDate",
        "year": "2020"
       },
       "publisher": {
        "name": "Utgiver",
        "type": "UnconfirmedPublisher"
       },
       "type": "LiteraryArtsMonograph"
      }
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant