Skip to content

Re-adding Create Account Components#5

Open
DarrylBrooks97 wants to merge 6 commits intoBLACC-Smith:mainfrom
DarrylBrooks97:create-account
Open

Re-adding Create Account Components#5
DarrylBrooks97 wants to merge 6 commits intoBLACC-Smith:mainfrom
DarrylBrooks97:create-account

Conversation

@DarrylBrooks97
Copy link
Copy Markdown
Member

No description provided.

@DarrylBrooks97 DarrylBrooks97 added the Work In Progress No review is needed as the PR is still being worked on label Nov 22, 2020
@DarrylBrooks97 DarrylBrooks97 changed the title Removed package-lock.json Re-adding Create Account Components Nov 22, 2020
@DarrylBrooks97 DarrylBrooks97 added Ready For Code Review All changes are complete and removed Work In Progress No review is needed as the PR is still being worked on labels Nov 22, 2020
Copy link
Copy Markdown
Collaborator

@gt-codes gt-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAIN CHANGE
There'll be one component called Authenticate at the route /authenticate. You can rename the login component and route to authenticate. In this component, there'll be a ternary that shows either login or signup input fields. We don't need to have separate routes and extra code for something this simple

Comment on lines +32 to +33
createUser(props.email, props.password, setError);
}, [props.email, props.password, clicked]);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructure the props variable to what you need

<Login />
</Route>
<PrivateRoute loggedIn={user} path="/">
<Route path='/newaccount'>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change path to /signup

@@ -0,0 +1,87 @@
import React, { useState } from 'react';
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FOR THIS ENTIRE FILE
There'll be one component called Authenticate at the route /authenticate. You can rename the login component and route to authenticate. In this component, there'll be a ternary that shows either login or signup input fields. We don't need to have separate routes and extra code for something this simple

@DarrylBrooks97 DarrylBrooks97 added Work In Progress No review is needed as the PR is still being worked on and removed Ready For Code Review All changes are complete labels Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Work In Progress No review is needed as the PR is still being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants