Skip to content

Hide shuffle controls when disabled#710

Open
keilogic wants to merge 1 commit into
BLeeEZ:masterfrom
keilogic:hide-shuffle-buttons
Open

Hide shuffle controls when disabled#710
keilogic wants to merge 1 commit into
BLeeEZ:masterfrom
keilogic:hide-shuffle-buttons

Conversation

@keilogic
Copy link
Copy Markdown

@keilogic keilogic commented May 30, 2026

Summary

  • hide playlist/detail-header shuffle controls when the player shuffle button setting is disabled
  • hide shared player shuffle buttons instead of leaving them visible but inactive
  • keep non-shuffle Random controls available and update the display setting copy to match the hide behavior

Refs #312 item 1.

Validation

  • git diff --check

Not run: Swift/Xcode tests, because this Windows environment does not have swift or Xcode tooling installed.

@el-tiuri
Copy link
Copy Markdown
Contributor

el-tiuri commented Jun 1, 2026

Of note: the author seems to be using AI to try to get as many feature bounties as possible across as many repos as possible. My guess is that this is not or barely tested and the contributor will do no follow-up once the bounty has been collected.

I don’t know wether this should be merged, but it feels against the spirit of open source and the feature bounties.

@keilogic
Copy link
Copy Markdown
Author

keilogic commented Jun 2, 2026

Thanks for raising the concern. I’ll follow up on this PR if maintainers find an issue.

The change is deliberately narrow: it hides the shuffle controls that are gated by the existing player-shuffle setting, keeps the non-shuffle Random controls available, and updates the setting copy to match that behavior. I did not run Swift/Xcode tests because I do not have that toolchain on this Windows host, and I called that out in the PR body.

I also removed the payment line from the PR body so review can stay focused on the code. If someone can run an app build and sees a UI or behavior regression, I’ll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants