ci: fix GHA cache permissions and guard cache-to for fork PRs#246
Merged
plexoos merged 6 commits intopr/update-workflow-matrixfrom Mar 31, 2026
Merged
ci: fix GHA cache permissions and guard cache-to for fork PRs#246plexoos merged 6 commits intopr/update-workflow-matrixfrom
plexoos merged 6 commits intopr/update-workflow-matrixfrom
Conversation
…uest workflow Agent-Logs-Url: https://github.com/BNLNPPS/eic-opticks/sessions/48197893-cac7-42cf-9f79-1a3a55e937d8 Co-authored-by: plexoos <5005079+plexoos@users.noreply.github.com>
…workflow Agent-Logs-Url: https://github.com/BNLNPPS/eic-opticks/sessions/48197893-cac7-42cf-9f79-1a3a55e937d8 Co-authored-by: plexoos <5005079+plexoos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] ci: apply feedback on image build matrix and workflows adjustments
ci: fix GHA cache permissions and guard cache-to for fork PRs
Mar 26, 2026
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
a2baeaf to
ec4058d
Compare
…copilot/sub-pr-244
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pull-request CI workflow to make GitHub Actions cache usage reliable by explicitly granting the needed permissions and preventing cache writes when the workflow runs for forked pull requests (where the token cannot have write access).
Changes:
- Add explicit job-level
permissionsforbuild-release-smoketo enabletype=ghacache writes. - Introduce
CACHE_SCOPEandIS_FORKenvironment variables to centralize cache scoping and detect fork PRs. - Guard
cache-toso it is only set for non-fork pull requests, avoiding failures on forks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type=ghacache inbuild-release-smokewas missing the requiredactions: writepermission, andcache-towas unconditionally set — causing failures on fork PRs where the token cannot be granted write access.Changes
permissions: contents: read+actions: writetobuild-release-smokejobCACHE_SCOPEenv var and setIS_FORKfromgithub.event.pull_request.head.repo.full_name != github.repository;cache-tois only populated for non-fork PRs:⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.