Skip to content

Fix uninitialized member state in IKSolverVR causing erratic elbow/arm IK #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix uninitialized member state in IKSolverVR causing erratic elbow/arm IK #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db710c7
Initial plan
Copilot May 4, 2026
26dfd55
Fix uninitialized member state in IKSolverVR
Copilot May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/customTypes/FinalIK/IKSolverVR.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ namespace VRMQavatars::FinalIK {
void SetIKPositionWeight(float weight);
void Update();

bool initiated;
bool firstInitiation;
bool initiated = false;
bool firstInitiation = true;
Sombrero::FastVector3 IKPosition;
float IKPositionWeight = 1.0f;
std::function<void()> OnPostInitiate;
std::function<void()> OnPostUpdate;
std::function<void()> OnPreInitiate;
std::function<void()> OnPreUpdate;
UnityEngine::Transform* root;
UnityEngine::Transform* root = nullptr;

// IKSolverVR

Expand Down Expand Up @@ -76,11 +76,11 @@ namespace VRMQavatars::FinalIK {
std::vector<Sombrero::FastVector3> defaultLocalPositions = std::vector<Sombrero::FastVector3>(21);
Sombrero::FastVector3 rootVelocity = Sombrero::FastVector3::zero();
Sombrero::FastVector3 bodyOffset = Sombrero::FastVector3::zero();
int supportLegIndex = 0;
int supportLegIndex = -1;
int lastLOD = 0;
int LOD = 0;
bool plantFeet = true;
VirtualBone* rootBone;
VirtualBone* rootBone = nullptr;
Spine* spine = new Spine();
Arm* leftArm = new Arm();
Arm* rightArm = new Arm();
Expand Down