Skip to content

Hide self testing naming in tests #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BabetteB merged 6 commits into from
Mar 18, 2026
Merged

Hide self testing naming in tests #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc76d16
feat: add mock test repo
BabetteB Mar 18, 2026
aeece11
chore: remove indication of ArchLens in tests
BabetteB Mar 18, 2026
8fbbf15
fix: exclude test repo from unused imports
BabetteB Mar 18, 2026
b8eabbc
fix: add missing folder for test repo
BabetteB Mar 18, 2026
9184131
feat: add missing namespace
BabetteB Mar 18, 2026
121122a
chore: github cannot recognise that we should be able to rebase and m…
BabetteB Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- name: Remove unused imports
run: >
dotnet format style src/c-sharp/Archlens.sln --severity warn --no-restore --verbosity diagnostic
dotnet format style src/c-sharp/Archlens.sln --severity warn --no-restore --verbosity diagnostic --exclude "src/ArchlensTests/TestRepo"
# To exclude files or folders, append e.g.:
# --exclude "src/c-sharp/SomeFolder/**/*.cs"
# --exclude "src/c-sharp/SomeFolder/**"
Expand Down
366 changes: 183 additions & 183 deletions src/ArchlensTests/Application/DependencyGraphBuilderTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

98 changes: 49 additions & 49 deletions src/ArchlensTests/Domain/RendererBaseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public sealed partial class RendererBaseTests : IDisposable
FullRootPath: _fs.Root
),
Format: default,
Views: [new View("completeView", [], []), new View("ignoringView", [], ["./Infra/"])],
Views: [new View("completeView", [], []), new View("ignoringView", [], ["./Warehouse/"])],
SaveLocation: $"{_fs.Root}/diagrams"
);

Expand Down Expand Up @@ -67,8 +67,8 @@ public void PlantUMLRendererRendersCorrectly()
Assert.NotEmpty(result);
Assert.StartsWith("@startuml", result);
Assert.Contains("title completeView", result);
Assert.Contains("package \"Domain\" as Domain", result);
Assert.Contains("Infra", result);
Assert.Contains("package \"Inventory\" as Inventory", result);
Assert.Contains("Warehouse", result);
Assert.EndsWith("@enduml", result.TrimEnd());
}

Expand All @@ -84,8 +84,8 @@ public void PlantUMLRendererIgnoresPackages()
Assert.NotEmpty(result);
Assert.StartsWith("@startuml", result);
Assert.Contains("title ignoringView", result);
Assert.Contains("package \"Domain\" as Domain", result);
Assert.DoesNotContain("Infra", result);
Assert.Contains("package \"Inventory\" as Inventory", result);
Assert.DoesNotContain("Warehouse", result);
Assert.EndsWith("@enduml", result.TrimEnd());
}

Expand All @@ -99,26 +99,26 @@ public void JsonRendererRendersDiffCorrectly()
var remoteGraph = TestDependencyGraph.MakeDependencyGraph(opts.BaseOptions.ProjectRoot);
var localGraph = TestDependencyGraph.MakeDependencyGraph(opts.BaseOptions.ProjectRoot);

var records = RelativePath.Directory(rootPath, "./Domain/Models/Records/");
var dependencyParserFactory = RelativePath.File(rootPath, "./Infra/Factories/DependencyParserFactory.cs");
var labels = RelativePath.Directory(rootPath, "./Inventory/Stock/Labels/");
var stockSupplier = RelativePath.File(rootPath, "./Warehouse/Suppliers/StockSupplier.cs");

localGraph.RemoveDependency(dependencyParserFactory, records); // local removes one Infra -> Domain
localGraph.AddDependency(records, dependencyParserFactory);
localGraph.AddDependency(records, dependencyParserFactory);
localGraph.RemoveDependency(stockSupplier, labels); // local removes one Warehouse -> Inventory
localGraph.AddDependency(labels, stockSupplier);
localGraph.AddDependency(labels, stockSupplier);

var result = renderer.RenderDiffView(localGraph, remoteGraph, opts.Views[0], opts);

var newEdge = $$"""
"state": "CREATED",
"fromPackage": "Domain",
"toPackage": "Infra",
"fromPackage": "Inventory",
"toPackage": "Warehouse",
"label": "2 (+2)",
""";

var deletedEdge = $$"""
"state": "DELETED",
"fromPackage": "Infra",
"toPackage": "Domain",
"fromPackage": "Warehouse",
"toPackage": "Inventory",
"label": "4 (-1)",
""";

Expand Down Expand Up @@ -149,22 +149,22 @@ public void PlantUMLRendererRendersDiffCorrectly()
var remoteGraph = TestDependencyGraph.MakeDependencyGraph(opts.BaseOptions.ProjectRoot);
var localGraph = TestDependencyGraph.MakeDependencyGraph(opts.BaseOptions.ProjectRoot);

var records = RelativePath.Directory(rootPath, "./Domain/Models/Records/");
var dependencyParserFactory = RelativePath.File(rootPath, "./Infra/Factories/DependencyParserFactory.cs");
var labels = RelativePath.Directory(rootPath, "./Inventory/Stock/Labels/");
var stockSupplier = RelativePath.File(rootPath, "./Warehouse/Suppliers/StockSupplier.cs");

localGraph.AddDependency(records, dependencyParserFactory);
localGraph.RemoveDependency(dependencyParserFactory, records);
localGraph.AddDependency(labels, stockSupplier);
localGraph.RemoveDependency(stockSupplier, labels);

string result = renderer.RenderDiffView(localGraph, remoteGraph, opts.Views[0], opts);

var newEdge = "Domain --> Infra #Green : 1 (+1)";
var deletedEdge = "Infra --> Domain #Red : 4 (-1)";
var newEdge = "Inventory --> Warehouse #Green : 1 (+1)";
var deletedEdge = "Warehouse --> Inventory #Red : 4 (-1)";

Assert.NotEmpty(result);
Assert.StartsWith("@startuml", result);
Assert.Contains("title completeView", result);
Assert.Contains("package \"Domain\" as Domain", result);
Assert.Contains("Infra", result);
Assert.Contains("package \"Inventory\" as Inventory", result);
Assert.Contains("Warehouse", result);
Assert.EndsWith("@enduml", result.TrimEnd());

Assert.Contains(newEdge, result);
Expand All @@ -188,11 +188,11 @@ public void EdgesAreOrderedByFromThenTo()
[Fact]
public void IgnoredPackageAbsentFromOutput()
{
var opts = MakeOptions(ignore: ["./Infra/"]);
var opts = MakeOptions(ignore: ["./Warehouse/"]);
var result = new PlantUMLRenderer().RenderView(
TestDependencyGraph.MakeDependencyGraph(_fs.Root), opts.Views[0], opts);

Assert.DoesNotContain("Infra", result);
Assert.DoesNotContain("Warehouse", result);
}

[Fact]
Expand All @@ -202,41 +202,41 @@ public void NonIgnoredPackagesPresentInOutput()
var result = new PlantUMLRenderer().RenderView(
TestDependencyGraph.MakeDependencyGraph(_fs.Root), opts.Views[0], opts);

Assert.Contains("Domain", result);
Assert.Contains("Infra", result);
Assert.Contains("Inventory", result);
Assert.Contains("Warehouse", result);
}

[Fact]
public void NoEdgesReferenceIgnoredPackage()
{
var opts = MakeOptions(ignore: ["./Infra/"]);
var opts = MakeOptions(ignore: ["./Warehouse/"]);
var result = new JsonRenderer().RenderView(
TestDependencyGraph.MakeDependencyGraph(_fs.Root), opts.Views[0], opts);

var edgeSection = result.Contains("\"edges\"")
? result[result.IndexOf("\"edges\"")..]
: "";
Assert.DoesNotContain("\"Infra\"", edgeSection);
Assert.DoesNotContain("\"Warehouse\"", edgeSection);
}

[Fact]
public void DepthOneHidesSubPackages()
{
var opts = MakeOptions(packages: [new Package("./Domain/", 1)]);
var opts = MakeOptions(packages: [new Package("./Inventory/", 1)]);
var result = new JsonRenderer().RenderView(
TestDependencyGraph.MakeDependencyGraph(_fs.Root), opts.Views[0], opts);

Assert.DoesNotContain("Models", result);
Assert.DoesNotContain("Stock", result);
}

[Fact]
public void DepthTwoShowsDirectChildren()
{
var opts = MakeOptions(packages: [new Package("./Domain/", 2)]);
var opts = MakeOptions(packages: [new Package("./Inventory/", 2)]);
var result = new JsonRenderer().RenderView(
TestDependencyGraph.MakeDependencyGraph(_fs.Root), opts.Views[0], opts);

Assert.Contains("Models", result);
Assert.Contains("Stock", result);
}

[Fact]
Expand All @@ -256,7 +256,7 @@ public void NodeOnlyInLocalIsMarkedCreated()
var opts = MakeOptions();
var remote = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var local = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
remote.RemoveProjectItemRecursive(RelativePath.Directory(_fs.Root, "./Infra/"));
remote.RemoveProjectItemRecursive(RelativePath.Directory(_fs.Root, "./Warehouse/"));

var result = Minify(new JsonRenderer().RenderDiffView(local, remote, opts.Views[0], opts));

Expand All @@ -269,7 +269,7 @@ public void NodeOnlyInRemoteIsMarkedDeleted()
var opts = MakeOptions();
var remote = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var local = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
local.RemoveProjectItemRecursive(RelativePath.Directory(_fs.Root, "./Infra/"));
local.RemoveProjectItemRecursive(RelativePath.Directory(_fs.Root, "./Warehouse/"));

var result = Minify(new JsonRenderer().RenderDiffView(local, remote, opts.Views[0], opts));

Expand All @@ -293,8 +293,8 @@ public void NewEdgeIsMarkedCreated()
var remote = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var local = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
local.AddDependency(
RelativePath.Directory(_fs.Root, "./Domain/Models/Records/"),
RelativePath.File(_fs.Root, "./Infra/Factories/DependencyParserFactory.cs"));
RelativePath.Directory(_fs.Root, "./Inventory/Stock/Labels/"),
RelativePath.File(_fs.Root, "./Warehouse/Suppliers/StockSupplier.cs"));

var result = Minify(new JsonRenderer().RenderDiffView(local, remote, opts.Views[0], opts));

Expand All @@ -308,8 +308,8 @@ public void IncreasedEdgeCountShowsGreenLabelInPlantUML()
var remote = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var local = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
local.AddDependency(
RelativePath.Directory(_fs.Root, "./Domain/Models/Records/"),
RelativePath.File(_fs.Root, "./Infra/Factories/DependencyParserFactory.cs"));
RelativePath.Directory(_fs.Root, "./Inventory/Stock/Labels/"),
RelativePath.File(_fs.Root, "./Warehouse/Suppliers/StockSupplier.cs"));

var result = new PlantUMLRenderer().RenderDiffView(local, remote, opts.Views[0], opts);

Expand All @@ -324,8 +324,8 @@ public void DecreasedEdgeCountShowsRedLabelInPlantUML()
var remote = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var local = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
local.RemoveDependency(
RelativePath.File(_fs.Root, "./Infra/Factories/DependencyParserFactory.cs"),
RelativePath.Directory(_fs.Root, "./Domain/Models/Records/"));
RelativePath.File(_fs.Root, "./Warehouse/Suppliers/StockSupplier.cs"),
RelativePath.Directory(_fs.Root, "./Inventory/Stock/Labels/"));

var result = new PlantUMLRenderer().RenderDiffView(local, remote, opts.Views[0], opts);

Expand All @@ -338,18 +338,18 @@ public void IntraPackageDependencyProducesNoSelfLoopEdge()
{
var opts = MakeOptions();
var graph = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var recordA = RelativePath.File(_fs.Root, "./Domain/Models/RecordA.cs");
var recordB = RelativePath.File(_fs.Root, "./Domain/Models/RecordB.cs");
var itemA = RelativePath.File(_fs.Root, "./Inventory/Stock/ItemA.cs");
var itemB = RelativePath.File(_fs.Root, "./Inventory/Stock/ItemB.cs");

graph.UpsertProjectItem(recordA, ProjectItemType.File);
graph.UpsertProjectItem(recordB, ProjectItemType.File);
graph.UpsertProjectItem(itemA, ProjectItemType.File);
graph.UpsertProjectItem(itemB, ProjectItemType.File);
graph.AddDependency(
RelativePath.File(_fs.Root, "./Domain/Models/RecordA.cs"),
RelativePath.File(_fs.Root, "./Domain/Models/RecordB.cs"));
RelativePath.File(_fs.Root, "./Inventory/Stock/ItemA.cs"),
RelativePath.File(_fs.Root, "./Inventory/Stock/ItemB.cs"));

var result = Minify(new JsonRenderer().RenderView(graph, opts.Views[0], opts));

Assert.DoesNotContain(@"""fromPackage"":""Domain"",""toPackage"":""Domain""", result);
Assert.DoesNotContain(@"""fromPackage"":""Inventory"",""toPackage"":""Inventory""", result);
}

[Fact]
Expand Down Expand Up @@ -517,8 +517,8 @@ public void DiffRenderIsDeterministic()
var local = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
var remote = TestDependencyGraph.MakeDependencyGraph(_fs.Root);
local.AddDependency(
RelativePath.Directory(_fs.Root, "./Domain/Models/Records/"),
RelativePath.File(_fs.Root, "./Infra/Factories/DependencyParserFactory.cs"));
RelativePath.Directory(_fs.Root, "./Inventory/Stock/Labels/"),
RelativePath.File(_fs.Root, "./Warehouse/Suppliers/StockSupplier.cs"));

Assert.Equal(
new JsonRenderer().RenderDiffView(local, remote, opts.Views[0], opts),
Expand Down
12 changes: 6 additions & 6 deletions src/ArchlensTests/Infra/ConfigManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public async Task RenderOptions_View_LoadsPackagesWithPathAndDepth()
Views: """
{
"v": {
"packages": [{ "path": "./Domain/", "depth": 2 }],
"packages": [{ "path": "./Inventory/", "depth": 2 }],
"ignorePackages": []
}
}
Expand All @@ -334,7 +334,7 @@ public async Task RenderOptions_View_LoadsPackagesWithPathAndDepth()
var (_, _, renderOptions, _) = await Manager(path).LoadAsync();
var pkg = Assert.Single(renderOptions.Views[0].Packages);

Assert.Equal("./Domain/", pkg.Path);
Assert.Equal("./Inventory/", pkg.Path);
Assert.Equal(2, pkg.Depth);
}

Expand All @@ -345,7 +345,7 @@ public async Task RenderOptions_View_PackageDepth_DefaultsToZero_WhenOmitted()
Views: """
{
"v": {
"packages": [{ "path": "./Domain/" }],
"packages": [{ "path": "./Inventory/" }],
"ignorePackages": []
}
}
Expand All @@ -364,15 +364,15 @@ public async Task RenderOptions_View_LoadsIgnorePackages()
{
"v": {
"packages": [],
"ignorePackages": ["./Infra/", "./Application/"]
"ignorePackages": ["./Warehouse/", "./Shop/"]
}
}
"""));

var (_, _, renderOptions, _) = await Manager(path).LoadAsync();
var view = Assert.Single(renderOptions.Views);
Assert.Contains("./Infra/", view.IgnorePackages);
Assert.Contains("./Application/", view.IgnorePackages);
Assert.Contains("./Warehouse/", view.IgnorePackages);
Assert.Contains("./Shop/", view.IgnorePackages);
}

[Fact]
Expand Down
Loading
Loading