Skip to content

4 done #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isabellamagnusdottir wants to merge 1 commit into
base: t07-trunk
Choose a base branch
from
Open

4 done #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified CoDepend/.codepend/snapshot
View file
Open in desktop
Binary file not shown.
13 changes: 11 additions & 2 deletions CoDepend/Domain/RendererBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ public abstract class RendererBase
{
public abstract string FileExtension { get; }

// Normalized file extension with proper dot handling
private string NormalizedFileExtension => NormalizeExtension(FileExtension);

protected abstract string Render(RenderGraph graph, View view, RenderOptions options);

public string RenderView(ProjectDependencyGraph graph, View view, RenderOptions options)
Expand Down Expand Up @@ -96,12 +99,18 @@ public async Task SaveViewToFileAsync(string content, View view, RenderOptions o
Directory.CreateDirectory(dir);

var diffString = diff ? "-diff" : "";
var filename = $"{options.BaseOptions.ProjectName}{diffString}-{view.ViewName}.{FileExtension}";
var filename = $"{options.BaseOptions.ProjectName}{diffString}-{view.ViewName}{NormalizedFileExtension}";
var path = Path.Combine(dir, filename);

await File.WriteAllTextAsync(path, content, ct);
}

private static string NormalizeExtension(string ext)
{
ext = ext.Trim();
return ext.StartsWith('.') ? ext : "." + ext;
}

private static RenderGraph BuildRenderGraph(
ProjectDependencyGraph graph,
View view,
Expand Down Expand Up @@ -450,4 +459,4 @@ private static bool IsUnderAnyRoot(RelativePath path, IReadOnlySet<RelativePath>
{
return roots.Any(root => path.Value.StartsWith(root.Value, StringComparison.OrdinalIgnoreCase));
}
}
}