Skip to content

[WIP] BAH-1231 | Add validate PR workflow#63

Open
NoorShiuli wants to merge 1 commit into
Bahmni:masterfrom
NoorShiuli:BAH-1231
Open

[WIP] BAH-1231 | Add validate PR workflow#63
NoorShiuli wants to merge 1 commit into
Bahmni:masterfrom
NoorShiuli:BAH-1231

Conversation

@NoorShiuli

Copy link
Copy Markdown

No description provided.

@gsluthra

Copy link
Copy Markdown
Contributor

The PR seems fine to me. We just want to run the build with test and test-only, to ensure the build with unit tests passes when a PR is raised.

@gsluthra

Copy link
Copy Markdown
Contributor

@mohan-13 : please review. seems fine to me.

@gsluthra

Copy link
Copy Markdown
Contributor

The setupDB step failed. Please have a look. @NoorShiuli thanks!

@mohan-13

Copy link
Copy Markdown
Member

@NoorShiuli Thanks for taking this up. Since the tests would require a database service running pls look into it. You can use service containers in Github Actions. Look at the example here for postgres. You should be able to run mysql as well.

@mohan-13

Copy link
Copy Markdown
Member

Also there were some test failures in the repository. Please take a look at this JIRA. https://bahmni.atlassian.net/browse/BAH-1252. It would be great if you can fix the test cases and raise a seperate PR for it.

@NoorShiuli

Copy link
Copy Markdown
Author

@gsluthra @mohan-13 we have updated the validate_pr.yml file. Can you approve this, so that we check if setupDB step is passing?
cc: @manishmdx@gmail.com

@NoorShiuli

Copy link
Copy Markdown
Author

Also there were some test failures in the repository. Please take a look at this JIRA. https://bahmni.atlassian.net/browse/BAH-1252. It would be great if you can fix the test cases and raise a seperate PR for it.

Will check this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants