Conversation
angshu
approved these changes
Nov 2, 2025
|
|
||
| private String post(URI uri, String body, HttpHeaders httpHeaders) { | ||
| try { | ||
| HttpResponse httpResponse = httpClientInternal.post(authenticator.getRequestDetails(uri), body, httpHeaders); |
Member
There was a problem hiding this comment.
how about using try with resources instead of try - catch - finally. Check HttpResponse implements Closeable?
Member
Author
There was a problem hiding this comment.
HttpResponse is not closeable.
There is a ClosableHttpClient used by the HttpClientInternal which can be implemented for try with resources. We can improve that later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for POST method in web-clients. The post takes in a payload of any type T and parses the response in the requested format passed as returnType R.
JIRA: https://bahmni.atlassian.net/browse/BAH-4237