Conversation
angshu
commented
Dec 24, 2025
angshu
commented
Member
- removed the script evaluation in Container.jsx componentWillMount() method to constructor() as any error will result in complete breakdown. Moving to componentDidMount does resolve the problem but will re-render the entire form. Constructore seems to be just fine.
- added encodingutils to convert utf8 to base64 and visa versa
- updated scriptRunner to convert base64 to utf8
- updated effected tests
- removed the script evaluation in Container.jsx componentWillMount() method to constructor() as any error will result in complete breakdown. Moving to componentDidMount does resolve the problem but will re-render the entire form. Constructore seems to be just fine. - added encodingutils to convert utf8 to base64 and visa versa - updated scriptRunner to convert base64 to utf8 - updated effected tests
angshu
changed the title
mohan-13
reviewed
Dec 28, 2025
| this.setState({ data: updatedTree }); | ||
| try { | ||
| updatedTree = new ScriptRunner(this.state.data, this.props.patient).execute(initScript); | ||
| updatedTree = executeEventsFromCurrentRecord(updatedTree, updatedTree, this.props.patient); |
Member
There was a problem hiding this comment.
@angshu the executeEventsFromCurrentRecord function seems to be moved inside the if block so that it gets executed only when there is a onFormInit event. Is this intentional? Previously it seems to be invoked outside of if.
Member
Author
There was a problem hiding this comment.
yeah, it should be outside. will fix
mohan-13
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.