BAH-4730 | Introduce form control APIs to manage notes for observation#51
Open
angshu wants to merge 3 commits into
Open
BAH-4730 | Introduce form control APIs to manage notes for observation#51angshu wants to merge 3 commits into
angshu wants to merge 3 commits into
Conversation
mohan-13
reviewed
May 22, 2026
|
|
||
| // Textarea is auto-expanded when an existing comment is provided — no click needed. | ||
| expect(screen.getByRole('textbox')).toHaveValue('Some Comment'); | ||
| fireEvent.click(screen.getByRole('button')); |
Member
There was a problem hiding this comment.
This seems like a behaviour change. So during an edit when form is loaded with notes, the user will see the notes box only on click of the button is it ?
Member
Author
There was a problem hiding this comment.
should not be. during edit if the comment/note is captured, the note should be displayed automatically. unfortunately without edit feature, its not possible to test out now. Note: this lib is not available on older version of form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.