Skip to content

BAH-4209 | Extend eoc model#19

Merged
mohan-13 merged 18 commits into
masterfrom
EXTEND-EOC-MODEL
Nov 2, 2025
Merged

BAH-4209 | Extend eoc model#19
mohan-13 merged 18 commits into
masterfrom
EXTEND-EOC-MODEL

Conversation

@angshu

@angshu angshu commented Oct 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Extended model (liquibase) - Episode model extension for status, period (date start, date end), type/classification, reasons, Attributes (type definition and Values), Introduced resource for EpisodeAttribute
  • New reference table for Episode and Visit.

angshu added 14 commits October 12, 2025 19:17
@angshu
Extending episode model for patient ref, reasons, period, status. Als…
c165aec 
…o adding episode attribute model
@angshu
Adding episode.type as classification of episode
9908e43
@angshu
Adding location to Episode
c991a30
@angshu
Removing Location from Episode
c7d0c1f
@angshu
bumping version to 1.3.0-SNAPSHOT
dcf8371
@angshu
Added Episode Status History. Added integration test
63cbd28
@angshu
Minor improvement.
dd81018
@angshu
minor code improvement
ead59b5
@angshu
Squashing the liquibase episode model
1535744
@angshu
fixing liquibase error for conflicting id
5e7c8f3
@angshu
Created Dao and service and resource controller for Episode Attribute…
180f9af 
… type
@angshu
Refactoring
6a69ac2 
- the dao package had redundant dao.impl.imp structure.
- removed dependency of webservices.rest-omod-common, as its has transitive dependency of webservices.rest-omod
@angshu
Added tests, curved out a helper test class, updated target build for…
69a97e5 
… Java 8
@angshu
added version for maven-compiler-plugin
4dce0dd
mohan-13
mohan-13 reviewed Nov 1, 2025
View reviewed changes
Comment thread api/src/main/java/org/openmrs/module/episodes/Episode.java Outdated
Comment thread api/src/main/java/org/openmrs/module/episodes/service/EpisodeAttributeTypeService.java Outdated
Comment thread api/src/main/java/org/openmrs/module/episodes/service/EpisodeService.java
Comment thread api/src/main/java/org/openmrs/module/episodes/Episode.java Outdated
@mohan-13

mohan-13 commented Nov 1, 2025

Copy link
Copy Markdown
Member

@angshu I can also see that there is no privilege check happening on the /episode-attribute-type resource. May be because the service is not registered to go through OpenMRS interceptors ?

image

@mohan-13

mohan-13 commented Nov 1, 2025

Copy link
Copy Markdown
Member

The PR description says a reference for episode and visit is added. I couldn't see any new table @angshu ?

@angshu

angshu commented Nov 1, 2025

Copy link
Copy Markdown
Member Author

@angshu I can also see that there is no privilege check happening on the /episode-attribute-type resource. May be because the service is not registered to go through OpenMRS interceptors ?

Yes. But doing that, will break Bahmni-core programs. Thought of doing this in another PR.

@angshu

angshu commented Nov 1, 2025

Copy link
Copy Markdown
Member Author

The PR description says a reference for episode and visit is added. I couldn't see any new table @angshu ?

there is a table "episode_visit", which maps to set in episode model

@mohan-13

mohan-13 commented Nov 1, 2025

Copy link
Copy Markdown
Member

The PR description says a reference for episode and visit is added. I couldn't see any new table @angshu ?

there is a table "episode_visit", which maps to set in episode model

alright, missed that

@mohan-13 mohan-13 merged commit bd87d61 into master Nov 2, 2025
2 checks passed
@mohan-13 mohan-13 deleted the EXTEND-EOC-MODEL branch November 2, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohan-13 mohan-13 mohan-13 approved these changes

Assignees

@mohan-13 mohan-13

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angshu @mohan-13