BAH-2211 | Implementing feature toggle for speech assistant#4
Open
anjali-arakka wants to merge 8 commits into
Open
BAH-2211 | Implementing feature toggle for speech assistant#4anjali-arakka wants to merge 8 commits into
anjali-arakka wants to merge 8 commits into
Conversation
anjali-arakka
requested review from
N0-man,
amankrayush and
pajmera4
as code owners
anjali-arakka
requested review from
NikhithaKom-TW
and removed request for
NikhithaKom-TW
…deploy speech-assistant to ec2 machine (#2) Co-authored-by: Priyanka Ajmera <priyanka.ajmera@thoughtworks.com>
amankrayush
force-pushed
the
BAH-2279
branch
from
0ab50e8 to
c1ce2aa
Compare
N0-man
reviewed
Oct 4, 2022
|
|
||
| services: | ||
|
|
||
| speech-assistant-proxy: |
Collaborator
There was a problem hiding this comment.
We added an Nginx proxy just for supporting toggle Boolean value on disk?
Collaborator
There was a problem hiding this comment.
yes but we are thinking to use this Nginx proxy for serving bundle.js file as well
anjali-arakka
force-pushed
the
BAH-2279
branch
from
09d098f to
497859b
Compare
anjali-arakka
force-pushed
the
BAH-2279
branch
from
497859b to
aa533fa
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is a new feature being developed, we do not know how comfortable the clinicians would be with the feature. Therefore, in order to ensure that the doctors are not irritated by the presence of the button on the screen, in case they are not using it for various reasons (hardware unavailability, etc), we would them to have the option of feature toggle , so that they can turn it off as and when required.