Skip to content

Ensure constant and class constant types are returned#155

Closed
Fladolcetta wants to merge 2 commits into
masterfrom
flad/ConstantsOnly
Closed

Ensure constant and class constant types are returned#155
Fladolcetta wants to merge 2 commits into
masterfrom
flad/ConstantsOnly

Conversation

@Fladolcetta

@Fladolcetta Fladolcetta commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

What:

  • Guardrail did not properly return the type of const (class or global).
  • When we validate strict_type this will break a bunch of functions.

Changes

  • Created a new util function to get type
  • Updated a bunch of code to effectively handle types of constants
  • Update TypeStringTable to resolve a warning
  • Added a BUNCH of tests and fixes for various const situations

@Fladolcetta
Fladolcetta requested review from a team and jongardiner as code owners February 10, 2026 16:55
@Fladolcetta Fladolcetta changed the title Constant Changes Only Ensure constant and class constant types are returned Feb 10, 2026
@Fladolcetta

Copy link
Copy Markdown
Contributor Author

Closing as we are fixing this in a more minimal way. See #157

@Fladolcetta
Fladolcetta deleted the flad/ConstantsOnly branch February 11, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant