feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck#169
Conversation
…ibuteDocumentationCheck Extend the existing OpenAPI attribute check to recognise and parse the 'multi-sourced-ownership' key in the x: extension array. The check now tracks whether this flag is set to true on a write endpoint, making the value available for downstream enforcement (e.g. BambooHR plugin checks that verify MultiSourcedOwnershipPolicy is wired into the call chain). Also adds a new test fixture (.5.inc) covering the four cases: missing flag, flag=true with the expected call present, flag=false, and no flag at all. Co-authored-by: Cursor <cursoragent@cursor.com>
…ocumentationCheck Co-authored-by: Cursor <cursoragent@cursor.com>
mechanism: fit-report
status: advisory
mode: pr
summary: "no-grounding — no Jira / Slite / Google Docs / committed-in-repo-path / allow-listed companion PR mentioned in PR prose or commits"
commit_sha: 224f2e5b7b6576261c5c911f9580457d9fbf94c5
generator: pr-fit-report/v1Fit ReportPR: feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck Note ℹ No fit report could be generated — no grounding sources were mentioned in the PR description, the PR title, or any commit message on this branch. The skill posts this comment to record that it ran; if grounding was missing by mistake, mention the relevant Jira ticket / Slite spec / Google Doc / committed in-repo path / companion PR in the PR description (or any commit message) and re-run. |
mechanism: team-standards-review
status: advisory
mode: pr
summary: "0 findings across 0 standards sources (0 AGENTS.md/CLAUDE.md, 0 tracked cursor rules, 0 repo-root review/contributing files, 0 inlined ADRs applied, 0 inlined REST API standards applied)"
findings_count: 0
commit_sha: 224f2e5b7b6576261c5c911f9580457d9fbf94c5
generator: pr-team-standards/v1Team-Standards ReviewPR: feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck Tip ✓ No drift observed — the diff appears to follow loaded standards. Findings(no standards drifts observed) Drafting inputs(no |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Closing per review feedback from @jongardiner. Guardrail core is open source and is intended to hold only generic, org-agnostic PHP checks. The enforcement now lives entirely in No core guardrail change is needed — closing this PR. |
Summary
OpenApiAttributeDocumentationCheckto recognise and parse themulti-sourced-ownershipkey in the OpenAPIx:extension array on controller write methodsx: ['multi-sourced-ownership' => true]is present, the check tracks it — enabling downstream BambooHR plugin checks (e.g.MultiSourcedOwnershipCheck) to enforce thatMultiSourcedOwnershipPolicyis wired into the call chain from that endpoint.5.inccovering the four cases: flag absent, flag=true with the resolver call present, flag=false, and flag=true with the call missing (1 expected error)Made with Cursor