Skip to content

feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck#169

Closed
kotis831 wants to merge 4 commits into
BambooHR:masterfrom
kotis831:kotis/multi-sourced-ownership-x-tag
Closed

feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck#169
kotis831 wants to merge 4 commits into
BambooHR:masterfrom
kotis831:kotis/multi-sourced-ownership-x-tag

Conversation

@kotis831

Copy link
Copy Markdown

Summary

  • Extends OpenApiAttributeDocumentationCheck to recognise and parse the multi-sourced-ownership key in the OpenAPI x: extension array on controller write methods
  • When x: ['multi-sourced-ownership' => true] is present, the check tracks it — enabling downstream BambooHR plugin checks (e.g. MultiSourcedOwnershipCheck) to enforce that MultiSourcedOwnershipPolicy is wired into the call chain from that endpoint
  • Adds test fixture .5.inc covering the four cases: flag absent, flag=true with the resolver call present, flag=false, and flag=true with the call missing (1 expected error)

Made with Cursor

…ibuteDocumentationCheck

Extend the existing OpenAPI attribute check to recognise and parse the
'multi-sourced-ownership' key in the x: extension array. The check now
tracks whether this flag is set to true on a write endpoint, making the
value available for downstream enforcement (e.g. BambooHR plugin checks
that verify MultiSourcedOwnershipPolicy is wired into the call chain).

Also adds a new test fixture (.5.inc) covering the four cases: missing flag,
flag=true with the expected call present, flag=false, and no flag at all.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kotis831
kotis831 requested review from a team and jongardiner as code owners May 14, 2026 21:53
…ocumentationCheck

Co-authored-by: Cursor <cursoragent@cursor.com>
@kotis831

Copy link
Copy Markdown
Author
mechanism: fit-report
status: advisory
mode: pr
summary: "no-grounding — no Jira / Slite / Google Docs / committed-in-repo-path / allow-listed companion PR mentioned in PR prose or commits"
commit_sha: 224f2e5b7b6576261c5c911f9580457d9fbf94c5
generator: pr-fit-report/v1

Fit Report

PR: feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck
Base → Head: masterkotis/multi-sourced-ownership-x-tag (224f2e5b7b6576261c5c911f9580457d9fbf94c5)
Generated: 2026-05-14 15:56 MDT (UTC-0600) — observations only

Note

No fit report could be generated — no grounding sources were mentioned in the PR description, the PR title, or any commit message on this branch. The skill posts this comment to record that it ran; if grounding was missing by mistake, mention the relevant Jira ticket / Slite spec / Google Doc / committed in-repo path / companion PR in the PR description (or any commit message) and re-run.

@kotis831

Copy link
Copy Markdown
Author
mechanism: team-standards-review
status: advisory
mode: pr
summary: "0 findings across 0 standards sources (0 AGENTS.md/CLAUDE.md, 0 tracked cursor rules, 0 repo-root review/contributing files, 0 inlined ADRs applied, 0 inlined REST API standards applied)"
findings_count: 0
commit_sha: 224f2e5b7b6576261c5c911f9580457d9fbf94c5
generator: pr-team-standards/v1

Team-Standards Review

PR: feat: add multi-sourced-ownership x-property detection to OpenApiAttributeDocumentationCheck
Base → Head: masterkotis/multi-sourced-ownership-x-tag (224f2e5b7b6576261c5c911f9580457d9fbf94c5)
Generated: 2026-05-14 15:56 MDT (UTC-0600) — observations only

Tip

No drift observed — the diff appears to follow loaded standards.

Findings

(no standards drifts observed)

Drafting inputs

(no .code-review/ skill overrides discovered)

@kotis831

Copy link
Copy Markdown
Author

Closing per review feedback from @jongardiner.

Guardrail core is open source and is intended to hold only generic, org-agnostic PHP checks. multi-sourced-ownership is a BambooHR-specific concept, so detecting/enforcing it does not belong in core OpenApiAttributeDocumentationCheck.

The enforcement now lives entirely in main as a self-contained Guardrail plugin: plugins/guardrail/MultiSourcedOwnershipCheck.php (BambooHR/main#129683). That plugin does its own x: ['multi-sourced-ownership' => true] tag detection and uses only the public plugin API (BaseCheck, symbolTable, emitErrorOnLine), so it requires no changes to this repo.

No core guardrail change is needed — closing this PR.

@kotis831 kotis831 closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant