Repository navigation
[Feature] 위치 기반 근처 공연 조회 기능 추가 - #98
Merged
Merged
Conversation
Contributor
|
전체적으로 수고하셨어요. 기존의 코드 스타일을 따라가려고 하셔서 감사합니다. Jacoco는 테스트 커버리지 통계보려고 한건데, 제가 짠 api가 아니면 다 테스트에서 죽어버리더라고요 다른 도메인들의 테스트 코드 자체를 바꾸거나 다시 짜야할 꺼 같긴해요. 그래서 테스트 다 못통과하고 하면 이렇게 깃허브 상에서 빨간 줄 뜨게 하는건데 걍 박아버릴께요 돌아가겠죠 머 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
작업 내용
GET /concerts/nearby)latitude,longitude,viewCount필드 추가viewCount1 증가 처리earthdistance익스텐션 기반 거리 계산 적용변경 사항
ConcertTable—latitude,longitude,view_count컬럼 추가ConcertRepository—findNearbyConcerts(),incrementViewCount()추가ConcertService/ConcertController—/nearby엔드포인트 추가DatabaseConfig—cube,earthdistance익스텐션 자동 생성참고
concerts테이블 재생성 필요