[Fix] #78 AI 추천글 매칭률 미표시 문제 수정 - #79
Hidden character warning
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 53 minutes and 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough추천 게시글 목록 컴포넌트와 쿼리 훅을 확장하여 흡연 여부를 태그로 표시하고 추천 게시글 데이터의 캐시 신선도 시간을 5분으로 지정합니다. 매칭률 표시 시 흡연 라벨도 함께 렌더링됩니다. Changes추천 게시글 기능 확장
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ CI 검증 결과✅ TypeScript: 통과 🎉 모든 검증을 통과했습니다. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/features/board/components/board/RecommendedPostList.tsx`:
- Line 57: The tags array currently always includes SMOKING_LABEL[post.smoking]
?? post.smoking which will push an undefined entry when post.smoking is falsy;
update the tags passed to the component in RecommendedPostList (where
tags={[SMOKING_LABEL[post.smoking] ?? post.smoking]}) to only include the
smoking value when post.smoking is present—e.g., build the tags array
conditionally (or filter out falsy values) so SMOKING_LABEL[post.smoking] or
post.smoking is added only if post.smoking is defined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cbe41a8e-aa38-40fe-8bd7-e2c5663b0410
📒 Files selected for processing (2)
src/features/board/components/board/RecommendedPostList.tsxsrc/features/board/hooks/useRecommendedPostList.ts
✅ CI 검증 결과✅ TypeScript: 통과 🎉 모든 검증을 통과했습니다. |
hdg0116
left a comment
There was a problem hiding this comment.
확인했습니다!! 바로 머지해주셔도 괜찮을 것 같아요!! 리뷰가 늦어져 죄송합니다🥹🥲
🗒️ PR 타입
🔗 관련 이슈
📌 작업사항
RecommendedPostList:RecruitCard에matchRateprop 전달 누락 수정 → 매칭률 바 표시RecommendedPostList:RecruitCard에 흡연 여부(smoking) 태그 추가 표시useRecommendedPostList:staleTime5분 설정 → 윈도우 포커스 복귀 시 불필요한 재요청 및 목록재정렬 방지
📸 스크린샷
📣 기타사항 및 코멘트
ai 정렬 시 매칭바가 안 뜨는 문제가 있어서 수정햇습니당...
그리고 해당 페이지에 진입할 때마다 ai 추천 정렬 api가 호출되고 잇어서 캐시 5분 설정도 해뒀어용
✅ 체크리스트
Summary by CodeRabbit
새로운 기능
성능 개선