Skip to content

[Fix] #78 AI 추천글 매칭률 미표시 문제 수정 - #79

Merged
nabbang6 merged 3 commits into
developfrom
fix/#78-모집글-AI-추천순-정렬-시-매칭률-미표시-문제-수정
May 30, 2026

Hidden character warning

The head ref may contain hidden characters: "fix/#78-\ubaa8\uc9d1\uae00-AI-\ucd94\ucc9c\uc21c-\uc815\ub82c-\uc2dc-\ub9e4\uce6d\ub960-\ubbf8\ud45c\uc2dc-\ubb38\uc81c-\uc218\uc815"
Merged

nabbang6 merged 3 commits into
developfrom
fix/#78-모집글-AI-추천순-정렬-시-매칭률-미표시-문제-수정

Conversation

@nabbang6

@nabbang6 nabbang6 commented May 29, 2026

Copy link
Copy Markdown
Collaborator

🗒️ PR 타입

  • 기능 추가
  • 기능 삭제
  • 버그 수정
  • 코드 리팩토링
  • 문서 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트

🔗 관련 이슈


📌 작업사항

  • RecommendedPostList: RecruitCardmatchRate prop 전달 누락 수정 → 매칭률 바 표시
  • RecommendedPostList: RecruitCard에 흡연 여부(smoking) 태그 추가 표시
  • useRecommendedPostList: staleTime 5분 설정 → 윈도우 포커스 복귀 시 불필요한 재요청 및 목록
    재정렬 방지

📸 스크린샷

image

📣 기타사항 및 코멘트

ai 정렬 시 매칭바가 안 뜨는 문제가 있어서 수정햇습니당...
그리고 해당 페이지에 진입할 때마다 ai 추천 정렬 api가 호출되고 잇어서 캐시 5분 설정도 해뒀어용


✅ 체크리스트

  • 로컬에서 빌드 및 테스트 완료
  • Label 지정 완료
  • 리뷰어 지정 완료
  • 코드 리뷰 반영 완료

Summary by CodeRabbit

  • 새로운 기능

    • 게시글에서 흡연 여부 정보가 태그로 표시됩니다.
  • 성능 개선

    • 추천 게시글 데이터 캐싱으로 로딩 성능이 개선되었습니다.

Review Change Stack

@nabbang6
nabbang6 requested a review from hdg0116 May 29, 2026 05:39
@nabbang6 nabbang6 self-assigned this May 29, 2026
@nabbang6 nabbang6 added the 🐞 Fix 버그 해결 label May 29, 2026
@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bangjjack-frontend-dev Ready Ready Preview, Comment May 29, 2026 5:46am

@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nabbang6, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 32 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6a4e965-a2cf-4094-83da-261ad0401ad3

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe062f and a0c63cb.

📒 Files selected for processing (1)
  • src/features/board/components/board/RecommendedPostList.tsx

Walkthrough

추천 게시글 목록 컴포넌트와 쿼리 훅을 확장하여 흡연 여부를 태그로 표시하고 추천 게시글 데이터의 캐시 신선도 시간을 5분으로 지정합니다. 매칭률 표시 시 흡연 라벨도 함께 렌더링됩니다.

Changes

추천 게시글 기능 확장

Layer / File(s) Summary
게시글 카드 태그 및 라벨 매핑
src/features/board/components/board/RecommendedPostList.tsx
SMOKING_LABEL 임포트를 추가하고, 각 게시글의 smoking 속성을 라벨 매핑을 통해 tags prop으로 RecruitCard에 전달합니다.
추천 게시글 쿼리 캐시 설정
src/features/board/hooks/useRecommendedPostList.ts
RECOMMENDED_STALE_TIME 상수를 5분으로 정의하고, useQuery 옵션의 staleTime에 설정하여 추천 게시글 캐시 신선도를 관리합니다.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Bangjjack/Bangjjack-Frontend#70: 이전 PR에서 추가된 SMOKING_LABEL 상수 및 추천 게시글 API를 기반으로 현재 PR이 라벨 매핑과 캐시 설정을 연동합니다.

Suggested reviewers

  • hdg0116
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 issue #78의 핵심 문제인 'AI 추천글 매칭률 미표시 문제'를 명확하게 반영하고 있으며, 간결하고 구체적입니다.
Description check ✅ Passed PR 설명서가 템플릿 구조를 대부분 따르고 있으며, PR 타입, 관련 이슈, 작업사항, 스크린샷, 체크리스트가 포함되어 있습니다.
Linked Issues check ✅ Passed 코드 변경사항이 issue #78의 요구사항인 'AI 추천순 정렬 시 매칭률 미표시 문제 수정'을 충분히 해결합니다.
Out of Scope Changes check ✅ Passed 모든 코드 변경사항이 issue #78의 범위 내에 있으며, 매칭률 표시, 흡연 태그 추가, 캐시 설정이 모두 관련 기능입니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#78-모집글-AI-추천순-정렬-시-매칭률-미표시-문제-수정

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

✅ CI 검증 결과

TypeScript: 통과
ESLint: 통과
Prettier: 통과
Build: 통과

🎉 모든 검증을 통과했습니다.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/features/board/components/board/RecommendedPostList.tsx`:
- Line 57: The tags array currently always includes SMOKING_LABEL[post.smoking]
?? post.smoking which will push an undefined entry when post.smoking is falsy;
update the tags passed to the component in RecommendedPostList (where
tags={[SMOKING_LABEL[post.smoking] ?? post.smoking]}) to only include the
smoking value when post.smoking is present—e.g., build the tags array
conditionally (or filter out falsy values) so SMOKING_LABEL[post.smoking] or
post.smoking is added only if post.smoking is defined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cbe41a8e-aa38-40fe-8bd7-e2c5663b0410

📥 Commits

Reviewing files that changed from the base of the PR and between 1f940b4 and 7fe062f.

📒 Files selected for processing (2)
  • src/features/board/components/board/RecommendedPostList.tsx
  • src/features/board/hooks/useRecommendedPostList.ts

Comment thread src/features/board/components/board/RecommendedPostList.tsx Outdated
@github-actions

Copy link
Copy Markdown

✅ CI 검증 결과

TypeScript: 통과
ESLint: 통과
Prettier: 통과
Build: 통과

🎉 모든 검증을 통과했습니다.

@hdg0116 hdg0116 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!! 바로 머지해주셔도 괜찮을 것 같아요!! 리뷰가 늦어져 죄송합니다🥹🥲

@nabbang6
nabbang6 merged commit 21b8895 into develop May 30, 2026
4 checks passed
@nabbang6
nabbang6 deleted the fix/#78-모집글-AI-추천순-정렬-시-매칭률-미표시-문제-수정 branch June 2, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 Fix 버그 해결

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fix] #78 룸메이트 모집글 추천순 정렬 시 매칭률 미표시 문제 수정

2 participants