fix: hide author when anonymized - #1127
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the signalement UI to hide the author display when the author has been anonymized, and refreshes the generated openapi-signalement client to reflect new/updated API capabilities (sources updates, commune settings retrieval, ProConnect endpoints, and extended models).
Changes:
- Hide author details in
SignalementHeaderwhenauthor.anonymizedAtis set. - Regenerate/extend the
openapi-signalementclient: newProconnectService,SourcesService.updateSource,SettingsService.getAllCommuneSettings, and updated DTO/model shapes. - Adjust the generated OpenAPI client default
BASEvalue for the signalement API.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/openapi-signalement/services/TilesService.ts | Minor docstring adjustment for tiles layers parameter. |
| src/lib/openapi-signalement/services/SourcesService.ts | Adds updateSource endpoint client method. |
| src/lib/openapi-signalement/services/SettingsService.ts | Adds getAllCommuneSettings endpoint client method. |
| src/lib/openapi-signalement/services/ProconnectService.ts | Adds generated ProConnect login/callback/logout client methods. |
| src/lib/openapi-signalement/models/UpdateSourceDTO.ts | Adds DTO for source updates (name/default author). |
| src/lib/openapi-signalement/models/Source.ts | Extends Source model with siret and defaultAuthor. |
| src/lib/openapi-signalement/models/CreateSourceDTO.ts | Extends source creation payload with siret and defaultAuthor. |
| src/lib/openapi-signalement/models/Author.ts | Extends Author model with emailDomain and anonymizedAt. |
| src/lib/openapi-signalement/index.ts | Exports new/updated generated model/service entries. |
| src/lib/openapi-signalement/core/OpenAPI.ts | Updates default OpenAPI BASE for the signalement client. |
| src/components/signalement/signalement-header.tsx | Hides the “par ” block when the author is anonymized. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.